* O_EXCL in NFSv3
@ 2011-04-12 7:35 J. R. Okajima
2011-04-12 11:56 ` Trond Myklebust
0 siblings, 1 reply; 3+ messages in thread
From: J. R. Okajima @ 2011-04-12 7:35 UTC (permalink / raw)
To: Trond Myklebust; +Cc: linux-kernel
Hello Trond,
The commit in v2.6.37
c0204fd 2010-09-17 NFS: Clean up nfs4_proc_create()
looks totally dropping O_EXCL flag from NFSv3.
But fs/nfs/nfs3proc.c:nfs3_proc_create() and
fs/nfsd/nfs3proc.c:nfsd3_proc_create() still expect O_EXCL to be passed.
And the commit log says "Clean up nfs4_proc_create()".
Is this change for NFSv3 intentional?
Actually O_EXCL in NFSv3 doesn't work in v2.6.37 and later.
J. R. Okajima
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: O_EXCL in NFSv3
2011-04-12 7:35 O_EXCL in NFSv3 J. R. Okajima
@ 2011-04-12 11:56 ` Trond Myklebust
2011-04-12 12:15 ` J. R. Okajima
0 siblings, 1 reply; 3+ messages in thread
From: Trond Myklebust @ 2011-04-12 11:56 UTC (permalink / raw)
To: J. R. Okajima; +Cc: linux-kernel
On Tue, 2011-04-12 at 16:35 +0900, J. R. Okajima wrote:
> Hello Trond,
>
> The commit in v2.6.37
> c0204fd 2010-09-17 NFS: Clean up nfs4_proc_create()
> looks totally dropping O_EXCL flag from NFSv3.
> But fs/nfs/nfs3proc.c:nfs3_proc_create() and
> fs/nfsd/nfs3proc.c:nfsd3_proc_create() still expect O_EXCL to be passed.
>
> And the commit log says "Clean up nfs4_proc_create()".
> Is this change for NFSv3 intentional?
> Actually O_EXCL in NFSv3 doesn't work in v2.6.37 and later.
Doesn't commit 8a0eebf66e3b1deae036553ba641a9c2bdbae678 (NFS: Fix NFSv3
exclusive open semantics) fix this? It should be in the stable tree.
--
Trond Myklebust
Linux NFS client maintainer
NetApp
Trond.Myklebust@netapp.com
www.netapp.com
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: O_EXCL in NFSv3
2011-04-12 11:56 ` Trond Myklebust
@ 2011-04-12 12:15 ` J. R. Okajima
0 siblings, 0 replies; 3+ messages in thread
From: J. R. Okajima @ 2011-04-12 12:15 UTC (permalink / raw)
To: Trond Myklebust; +Cc: linux-kernel
Trond Myklebust:
> Doesn't commit 8a0eebf66e3b1deae036553ba641a9c2bdbae678 (NFS: Fix NFSv3
> exclusive open semantics) fix this? It should be in the stable tree.
Ah, I can see the commit in v2.6.38.
So it is fixed already, sorry.
I just skipped all NFS tests for v2.6.38. due to the sillyrename
problem.
Also I know it was fixed just after v2.6.38(.0).
Thank you
J. R. Okajima
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2011-04-12 12:15 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-04-12 7:35 O_EXCL in NFSv3 J. R. Okajima
2011-04-12 11:56 ` Trond Myklebust
2011-04-12 12:15 ` J. R. Okajima
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox