From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753975AbcHSAx3 (ORCPT ); Thu, 18 Aug 2016 20:53:29 -0400 Received: from gloria.sntech.de ([95.129.55.99]:39301 "EHLO gloria.sntech.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753990AbcHSAwi (ORCPT ); Thu, 18 Aug 2016 20:52:38 -0400 From: Heiko Stuebner To: Kevin Hilman Cc: Finlye Xiao , srinivas.kandagatla@linaro.org, maxime.ripard@free-electrons.com, robh+dt@kernel.org, frowand.list@gmail.com, sre@kernel.org, dbaryshkov@gmail.com, dwmw2@infradead.org, mark.rutland@arm.com, nm@ti.com, rjw@rjwysocki.net, viresh.kumar@linaro.org, sboyd@codeaurora.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, wxt@rock-chips.com, jay.xu@rock-chips.com, rocky.hao@rock-chips.com, tim.chen@rock-chips.com, tony.xie@rock-chips.com, ulysses.huang@rock-chips.com, lin.huang@rock-chips.com Subject: Re: [PATCH v2 1/4] nvmem: rockchip-efuse: Change initcall to subsys Date: Fri, 19 Aug 2016 00:29:55 +0200 Message-ID: <2844104.lMUOkH8YJy@phil> User-Agent: KMail/5.2.3 (Linux/4.6.0-1-amd64; KDE/5.23.0; x86_64; ; ) In-Reply-To: References: <1471510341-63926-1-git-send-email-finley.xiao@rock-chips.com> <1471510341-63926-2-git-send-email-finley.xiao@rock-chips.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Am Donnerstag, 18. August 2016, 13:28:58 CEST schrieb Kevin Hilman: > Finlye Xiao writes: > > From: Finley Xiao > > > > We will register a cpufreq notifier for adjusting opp's voltage, and it > > need to fetch cpu's leakage from efuse in the notifier_call. so the efuse > > driver should probe before cpufreq driver. > > > > Signed-off-by: Finley Xiao > > Why can't this be handled with deferred probling? initcall ordering is > a can of worms. I think the issue is less between efuse and avs driver, but more between avs driver and cpufreq. The avs driver aims to modify the opp table and thus wants to do that / register the notifier before cpufreq starts. And as there is no direct connection between cpufreq and the avs driver, making cpufreq defer probing is probably not really easy.