Re: [PATCH 3/4] net: bridge: use device address list instead of dev_addr

Jiri Pirko
2009-04-14T10:17:24Z

Mon, Apr 13, 2009 at 04:54:00PM CEST, shemminger@vyatta.com wrote:
>> +static int another_port_has_addr(const struct net_bridge_port *p,
>> + struct net_bridge_fdb_entry *f)
>> +{
>> + struct net_bridge *br = p->br;
>> + struct net_bridge_port *op;
>> +
>> + list_for_each_entry(op, &br->port_list, list) {
>> + if (op != p && is_dev_addr(op->dev, f->addr.addr)) {
>> + f->dst = op;
>> + return 1;
>> + }
>> + }
>> + return 0;
>> +}
>
>Forwarding database is hot path, people sometimes run lots of devices
>on single bridge, doesn't this scale worse?
>
This only puts the original loop code to the function, so if compiler decides to
inline this there might be no difference.