Re: [PATCH 2/4] net: introduce a list of device addresses dev_addr_list

David Miller
2009-04-13T22:53:57Z

From: Jiri Pirko <jpirko@redhat.com>
Date: Mon, 13 Apr 2009 10:42:02 +0200

> @@ -210,6 +210,12 @@ struct dev_addr_list
> #define dmi_users da_users
> #define dmi_gusers da_gusers
>
> +struct hw_addr {
> + struct list_head list;
> + unsigned char addr[MAX_ADDR_LEN];
> + int refcount;
> +};
> +

Please don't pollute the global namespace with a structure name
like this. Use "netdev_hw_addr" or "net_hw_addr".

> +static inline int __hw_addr_add(struct list_head *list, unsigned char *addr,
> + int addr_len)

Please let the compiler inline things as it sees fit. These
aren't routines in some header file or anything like that.