Re: [PATCH] ARM: dts: qcom: msm8974-hammerhead: Add notification LED

[Luca Weiss <luca@z3ntu.xyz>]

Hi Pavel,

On Montag, 30. Mai 2022 09:06:19 CEST Pavel Machek wrote:
> Hi!
> 
> > From: Andr?? Almeida <andrealmeid@collabora.com>
> > 
> > Nexus 5 has a RGB LED connected to the TRILED and hence channels 7, 6 and
> > 5 of the LPG. Add a node describing this.
> > 
> > Signed-off-by: Luca Weiss <luca@z3ntu.xyz>
> > Signed-off-by: Andr?? Almeida <andrealmeid@collabora.com>
> > 
> > --- This patch depends on the PM8941 LPG patch:
> > https://lore.kernel.org/linux-arm-msm/20220504205411.1510667-1-bjorn.ander
> > sson@linaro.org/
> How does this LED end up looking in userland? We want to make sure all the
> phone RGB status LEDs end up using same path in /sys/..

Like this, on both hammerhead and FP2 (in a separate patch):

$ ls -al /sys/class/leds/rgb:status/
total 0
drwxr-xr-x 3 root root         0 Jan  5  1970 .
drwxr-xr-x 3 root root         0 Jan  5  1970 ..
-rw-rw-r-- 1 root feedbackd 4096 Jan  5  1970 brightness
lrwxrwxrwx 1 root root         0 May 30 13:59 device -> ../../../fc4cf000.spmi:pm8941@1:lpg
-r--r--r-- 1 root root      4096 Jan  5  1970 max_brightness
-r--r--r-- 1 root root      4096 Jan  5  1970 multi_index
-rw-rw-r-- 1 root feedbackd 4096 Jan  5  1970 multi_intensity
drwxr-xr-x 2 root root         0 May 30 13:59 power
lrwxrwxrwx 1 root root         0 Jan  5  1970 subsystem -> ../../../../../../../../../class/leds
-rw-r--r-- 1 root root         0 Jan  5  1970 trigger
-rw-r--r-- 1 root root      4096 Jan  5  1970 uevent

Regards
Luca

> 
> Best regards,
> 
> 									Pavel