From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 681AD26C3B0 for ; Thu, 24 Jul 2025 11:00:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.140.110.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1753354811; cv=none; b=XkqQRCRoCAVUHrIZzoDkuuZUrI71bhWGFBvNkR+pYCGS92mxfDFUj2in8a6y2jK2hWwPCy0SCMGYnjL+C/0i5qumsbk86OhnDFh+6uPP6SuDmcCPEygXzrVG6TbnSTgnlARw7exMoYiZ13x8KqbdOOimujJtpMVPdznc/s+3EEY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1753354811; c=relaxed/simple; bh=FvkpnvGIlnv/SOlkVlovKNOUznkfMlCOjFhauCBYzdw=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=MrPOzSdhCr6MTgtaROoAK7Cfy/IxJu1+meIlicgj08sUhPdbBjCDJvFI29+zwDKSBib1ygpPiPmTjcnebsnSj5RKH0unZRYigKp1kR4OhQHOc7UEWs1BhYVO8A/jwuykb30YLdt0w+OsrB3cGE2v6oPzwYqYxGhGL1ZsxmSzVTw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com; spf=pass smtp.mailfrom=arm.com; arc=none smtp.client-ip=217.140.110.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=arm.com Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id B44BB1A00; Thu, 24 Jul 2025 04:00:03 -0700 (PDT) Received: from [10.1.33.48] (e122027.cambridge.arm.com [10.1.33.48]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 8BDE83F66E; Thu, 24 Jul 2025 04:00:07 -0700 (PDT) Message-ID: <28500b47-6492-4bd6-a342-b21673948868@arm.com> Date: Thu, 24 Jul 2025 12:00:03 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v7 3/6] drm/panthor: Add support for Mali-G710, Mali-G510 and Mali-G310 To: Karunika Choo , dri-devel@lists.freedesktop.org Cc: nd@arm.com, Boris Brezillon , Liviu Dudau , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , linux-kernel@vger.kernel.org, Chia-I Wu References: <20250724092600.3225493-1-karunika.choo@arm.com> <20250724092600.3225493-4-karunika.choo@arm.com> Content-Language: en-GB From: Steven Price In-Reply-To: <20250724092600.3225493-4-karunika.choo@arm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 24/07/2025 10:25, Karunika Choo wrote: > This patch adds GPU model name and FW binary support for Mali-G710, > Mali-G510, and Mali-G310. > > Reviewed-by: Chia-I Wu > Reviewed-by: Liviu Dudau > Signed-off-by: Karunika Choo > --- > drivers/gpu/drm/panthor/panthor_fw.c | 2 ++ > drivers/gpu/drm/panthor/panthor_hw.c | 6 ++++++ > 2 files changed, 8 insertions(+) > > diff --git a/drivers/gpu/drm/panthor/panthor_fw.c b/drivers/gpu/drm/panthor/panthor_fw.c > index 36f1034839c2..b7b454d16f12 100644 > --- a/drivers/gpu/drm/panthor/panthor_fw.c > +++ b/drivers/gpu/drm/panthor/panthor_fw.c > @@ -1402,3 +1402,5 @@ int panthor_fw_init(struct panthor_device *ptdev) > } > > MODULE_FIRMWARE("arm/mali/arch10.8/mali_csffw.bin"); > +MODULE_FIRMWARE("arm/mali/arch10.10/mali_csffw.bin"); > +MODULE_FIRMWARE("arm/mali/arch10.12/mali_csffw.bin"); > diff --git a/drivers/gpu/drm/panthor/panthor_hw.c b/drivers/gpu/drm/panthor/panthor_hw.c > index f39010c0ca86..7f138974d43b 100644 > --- a/drivers/gpu/drm/panthor/panthor_hw.c > +++ b/drivers/gpu/drm/panthor/panthor_hw.c > @@ -15,8 +15,14 @@ static char *get_gpu_model_name(struct panthor_device *ptdev) > GPU_PROD_MAJOR(gpu_id)); > > switch (product_id) { > + case GPU_PROD_ID_MAKE(10, 2): > + return "Mali-G710"; > case GPU_PROD_ID_MAKE(10, 7): > return "Mali-G610"; > + case GPU_PROD_ID_MAKE(10, 3): > + return "Mali-G510"; > + case GPU_PROD_ID_MAKE(10, 4): > + return "Mali-G310"; Chia-I Wu pointed out these don't appear to have any logical ordering. I'd suggest ordering by arch major/product major. With that fixed: Reviewed-by: Steven Price > } > > return "(Unknown Mali GPU)";