From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932893AbcHXO4R convert rfc822-to-8bit (ORCPT ); Wed, 24 Aug 2016 10:56:17 -0400 Received: from gloria.sntech.de ([95.129.55.99]:42305 "EHLO gloria.sntech.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932657AbcHXO4P (ORCPT ); Wed, 24 Aug 2016 10:56:15 -0400 From: Heiko =?ISO-8859-1?Q?St=FCbner?= To: arvind Yadav Cc: mturquette@baylibre.com, sboyd@codeaurora.org, linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [v.1] clk:clk-rockchip:-of_iomap failed to remap then abort clock initialization. Date: Wed, 24 Aug 2016 16:56:08 +0200 Message-ID: <2854111.gibmD6ORig@diego> User-Agent: KMail/4.14.10 (Linux/4.6.0-1-amd64; KDE/4.14.22; x86_64; ; ) In-Reply-To: References: <1471101978-1881-1-git-send-email-arvind.yadav.cs@gmail.com> <1528160.BtdbmuP27T@diego> MIME-Version: 1.0 Content-Transfer-Encoding: 8BIT Content-Type: text/plain; charset="iso-8859-1" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Arvind, Am Mittwoch, 24. August 2016, 19:52:45 schrieb arvind Yadav: > yes, I am referring this code for clock control. Please definitly do not use that old gate driver anymore! Instead please look at the real clock drivers for specific Rockchip socs in the same directory. Which Rockchip soc are you working on? Heiko > On Tuesday 23 August 2016 09:45 PM, Heiko Stübner wrote: > > Hi Arvind, > > > > Am Samstag, 13. August 2016, 20:56:18 schrieb Arvind Yadav: > >> -check return of 'of_iomap'.if It's falied to remap then abort. > >> > >> -Unmap a region obtained by remap. iounmap frees the mapping when failed > >> to allocate the memory. > >> > >> Signed-off-by: Arvind Yadav > >> --- > >> > >> drivers/clk/rockchip/clk-rockchip.c | 7 ++++++- > > > > I've applied the patch, after rewording both patch subject and message > > [0]. > > > > That driver is deprecated for quite some time, see > > Documenation/devicetree/bindings/clock/rockchip.txt - so I'm hoping this > > is > > more of a random find and you're not actually using it? > > > > > > Thanks > > Heiko > > > > [0] > > https://git.kernel.org/cgit/linux/kernel/git/mmind/linux-rockchip.git/com > > mit/?id=023a8280b8355a0aebe094299afec8d8b7b264cd