From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752839AbcBLN6D (ORCPT <rfc822;w@1wt.eu>);
	Fri, 12 Feb 2016 08:58:03 -0500
Received: from mout.kundenserver.de ([212.227.126.135]:59038 "EHLO
	mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1752460AbcBLN6A (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Fri, 12 Feb 2016 08:58:00 -0500
From: Arnd Bergmann <arnd@arndb.de>
To: Deepa Dinamani <deepa.kernel@gmail.com>
Cc: linux-fsdevel@vger.kernel.org, y2038@lists.linaro.org,
        Dave Chinner <david@fromorbit.com>, "Theodore Ts'o" <tytso@mit.edu>,
        linux-kernel@vger.kernel.org
Subject: Re: [RFC v2b 3/5] fs: btrfs: Use vfs_time accessors
Date: Fri, 12 Feb 2016 14:57:55 +0100
Message-ID: <2859000.sW5HDiH6vW@wuerfel>
User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; )
In-Reply-To: <1455270349-3187-4-git-send-email-deepa.kernel@gmail.com>
References: <20160212092153.GA2368@deepa-ubuntu> <1455270349-3187-1-git-send-email-deepa.kernel@gmail.com> <1455270349-3187-4-git-send-email-deepa.kernel@gmail.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
X-Provags-ID: V03:K0:SZZkPuO4C6lxaGOqoZZcLlcMpNlIJLRdJW9tAbXVFoK+uy8IOT2
 NXqD8bwNPShg3AZHF6jgE3PRJBmV0z4HSyTcNwAMmyfFnAjfIGfRTZLFHPxwVDOyihxFVgp
 zQLhW1q08HbVSHTn6/xhnmtaN7D0QVUPtFpyAAeqV0I/16XiV5Mvg0uA+YAKlZydPI8t2Hh
 SeaJlGzvr6a8UG23wdKKQ==
X-UI-Out-Filterresults: notjunk:1;V01:K0:V/zjjzRGVYM=:x/BeEGcE0QIQpg7N9qmHdT
 QOTh532rtJ8DdNsN8nKHzMHo+DF+l8JqH4dLOx1mBLDXT/khWfMa++8gOe/UKzgideqwtS4+/
 hjgP+afDZ35cbekDYU/gKiJk/LPEHEUHlKwkydZ2M3o2fvMM6X7RNcLkfZU1JnZCSh0H7xeaI
 DvlDmdRV8ORsvP70KmzMyMEJTL/3YjI+q9K4bqqeUDMwKmV50XUhujIfrRaPxcLiwR7fh3AyZ
 9hNJp/SnLBomr+anW7ZMkkSjqw7ApY4l10bz/DTgsXVpGcSos+98ONwfSwV+DOHbr9aOyovkP
 4Ge98WKkR41f2EhzDo5BKXu/ZFFr/gvLdkJqRLNoIM/c3LeApvjoV3xKZ6jQvuke3OhLImqCN
 GzOPg5RKCbTvSXBrMSnwjnj7xyZimiWW+O2qa7PoC3lConaPFpRHr8I7PuQ84chXEq/QPfELV
 Qgjqnomi1oZhJBNiBEc4huDRmQv1BrpDJEvtXedmELB5mMCmU/7PGr/ua4JLXH/1Yh1RCvRh8
 P6uNF2PZiePLee3cmxZkbAvYOv4uSd/jnSgUfyjgmn0qVoWrMgbIzVCvWJMp/69jV48yijFJZ
 zG331xB2FVN8CWwPMOzFrY6UJSvnbqaT15VPUPBW3a2TRMAy5nfxd/lo7jSgsQJ8PAHE0FrVP
 AqT6C9EwJQUp3i1g0+rigvE33PpHCzPGb8eI50RN7EyU5t22XudpCP4OuYQgAQXT8Vj15c7P/
 s4bV/Vc4hHLfWCzA
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Friday 12 February 2016 01:45:47 Deepa Dinamani wrote:
> +       ts = vfs_time_to_timespec(inode->i_mtime);
> +       if (!timespec_equal(&ts, &now))
> +               inode->i_mtime = timespec_to_vfs_time(now);
> +
> +       ts = vfs_time_to_timespec(inode->i_mtime);
> +       if (!timespec_equal(&ts, &now))
> +               inode->i_ctime = timespec_to_vfs_time(now);
> 

The second one needs to be fs_time_to_timespec(inode->i_ctime), not i_mtime.

	Arnd