Re: [PATCH] kfifo: don't include dma-mapping.h in kfifo.h

Jiri Slaby
2024-10-15T07:47:35Z

On 14. 10. 24, 16:46, Christoph Hellwig wrote:
> Nothing in kfifo.h needs dma-mapping.h. Drop the include to
> reduce include bloat.
>
> Fixes: d52b761e4b1a ("kfifo: add kfifo_dma_out_prepare_mapped()")
> Signed-off-by: Christoph Hellwig <hch@lst.de>
> ---
> drivers/mailbox/omap-mailbox.c | 1 +
> include/linux/kfifo.h | 1 -
> samples/kfifo/dma-example.c | 1 +
> 3 files changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/mailbox/omap-mailbox.c b/drivers/mailbox/omap-mailbox.c
> index 6797770474a55d..680243751d625f 100644
> --- a/drivers/mailbox/omap-mailbox.c
> +++ b/drivers/mailbox/omap-mailbox.c
> @@ -15,6 +15,7 @@
> #include <linux/slab.h>
> #include <linux/kfifo.h>
> #include <linux/err.h>
> +#include <linux/io.h>

Oh, I've just noticed this. Why io.h?

--
js
suse labs