From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1755009AbcINJI4 (ORCPT <rfc822;w@1wt.eu>);
        Wed, 14 Sep 2016 05:08:56 -0400
Received: from mout.kundenserver.de ([212.227.126.131]:59255 "EHLO
        mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1750975AbcINJIw (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Wed, 14 Sep 2016 05:08:52 -0400
From: Arnd Bergmann <arnd@arndb.de>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: Baoyou Xie <baoyou.xie@linaro.org>,
        Michael Turquette <mturquette@baylibre.com>,
        Stephen Boyd <sboyd@codeaurora.org>,
        linux-clk <linux-clk@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        xie.baoyou@zte.com.cn
Subject: Re: [PATCH] clk: versatile: add missing header dependencies
Date: Wed, 14 Sep 2016 11:08:28 +0200
Message-ID: <2862092.ohvOYo10Tb@wuerfel>
User-Agent: KMail/5.1.3 (Linux/4.4.0-34-generic; KDE/5.18.0; x86_64; ; )
In-Reply-To: <CACRpkdb2BK2_CeSJ8kbuZH6_WwDRqabhcuMqRb+etCBwT80K7A@mail.gmail.com>
References: <1473834587-22526-1-git-send-email-baoyou.xie@linaro.org> <4600074.xAL28UziL1@wuerfel> <CACRpkdb2BK2_CeSJ8kbuZH6_WwDRqabhcuMqRb+etCBwT80K7A@mail.gmail.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
X-Provags-ID: V03:K0:mWb9dTsWNlw9v7Fmh11dnvzLdeYaB4bdmEaaGuYrjtNb5pva3+0
 HzpdU23vJfvz51XsvBQRIh3QH8YwnLy6097Hj8nCeWWNMVZs16RcECl8BP5mOgWTIWudvjx
 zsYSOVZSIh3demo4f3KSTdcWCm5WFEC0Mny3lWy76lMt2JzEB3ZxOPZsgejQrKT4U0FgSuT
 kSZx0V87iySDcqZJt9Vdw==
X-UI-Out-Filterresults: notjunk:1;V01:K0:PnYrBdmnFXY=:WGcIVEMkrUgmOiTbSI4mG4
 6MRClhomTwUJCA71STdnXeyLTqDkBL6/xApeNAc4NOabGdCVZevIho+7+l+iAgedmGZ/xInN3
 8ANnq7/qWZDjHB0I2oTTaSh7nVPNi5lhkavwm1+uRHDJpI5eWlF2dYAQ0CHWjFDtvvv4mkW6P
 mTeT4gAlXeSD5jlEYvYURBBaHSsAytMYCpTS7/wmD+aV8WQ0i6LMI9noFUrk93JmLTB2RdYHq
 xWlhw3JO6Syqpw56kIbT1+7P6fxlXpptMfXvydx/5szFETesaz4DT8iB+JYAjruQkKZIKMkSj
 qgvp2rDgIeY/t70iO8+eFzv8oa9DdFh7OFxno7VH9t9AARVBTzH2KRfEkh/7rvtTCXXD2V48u
 2r5wdyGUnlHrnKfaNoAOt2puFkY2OeopbBu/un3rk0q+iVF98jxgv0UHG0+uSdfQhZPP3Zxbt
 ZGb8BykO3zM2cyWZ7zQkmwXhCTaCvDvisSz5tnQ4QNKbVAAAKcwy96JIC3ALXOFHtjOJt55LC
 rWzYVYgFXXF9ZZLtpgWrJRdakNCNvBIqsRshZ2VVQnjwOh2JIaCf7gH+A9spXICTXAI28XxWE
 cF4C3FMWFj6Rbi+dYPl7tLkQKvDLLJYLj1Us427LwYy+VHnnM9fyDSqLcYeJJuV4bVzC33ql9
 3jsi8qbHHH4XGvLbD79NamASZeKM00fCAkpzUrG2PXQ5DziCWcUC9BZAkVgIoMGjEw1i/Ca5S
 UqYSVdLPElJ8Q1/6
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wednesday, September 14, 2016 11:04:29 AM CEST Linus Walleij wrote:
> On Wed, Sep 14, 2016 at 9:31 AM, Arnd Bergmann <arnd@arndb.de> wrote:
> > On Wednesday, September 14, 2016 2:29:47 PM CEST Baoyou Xie wrote:
> >> We get 1 warning when building kernel with W=1:
> >> drivers/clk/versatile/clk-realview.c:54:13: warning: no previous prototype for 'realview_clk_init' [-Wmissing-prototypes]
> >>
> >> In fact, this function is declared in clk-realview.h,
> >> so this patch add missing header dependencies.
> >>
> >> Signed-off-by: Baoyou Xie <baoyou.xie@linaro.org>
> >>
> >
> > Please leave this one for now. We are in the process of removing the
> > last caller of this function, and should just remove the header file
> > and the function definition in the next release.
> 
> +1 on this, leave it. I can clean it up for v4.10 or even
> for an -rc if you want it real neat in v4.9.
> 

I think v4.10 is fine: Baoyou has done a great job so far fixing a lot
of those warnings, but we already know that there will be a lot remaining
after v4.9, so v4.10 is the earliest possible version in which we
can turn on the warning by default.

	Arnd