Re: [PATCH v5 05/11] of: Add a KUnit test for overlays and test managed APIs

Stephen Boyd
2024-07-02T21:46:01Z

Quoting David Gow (2024-06-13 00:50:10)
> On Tue, 4 Jun 2024 at 06:38, Stephen Boyd <sboyd@kernel.org> wrote:
> >
> > Test the KUnit test managed overlay APIs. Confirm that platform devices
> > are created and destroyed properly. This provides us confidence that the
> > test managed APIs work correctly and can be relied upon to provide tests
> > with fake platform devices and device nodes via overlays compiled into
> > the kernel image.
> >
> > Cc: Rob Herring <robh@kernel.org>
> > Cc: Saravana Kannan <saravanak@google.com>
> > Cc: Daniel Latypov <dlatypov@google.com>
> > Cc: Brendan Higgins <brendan.higgins@linux.dev>
> > Cc: David Gow <davidgow@google.com>
> > Cc: Rae Moar <rmoar@google.com>
> > Reviewed-by: Rob Herring (Arm) <robh@kernel.org>
> > Signed-off-by: Stephen Boyd <sboyd@kernel.org>
> > ---
>
> This is looking good from my point of view, and passes on my test
> setup. One minor question (do we need both to select OF_OVERLAY and
> skip if it's not enabled?), but otherwise:

We don't need to skip if OF_OVERLAY isn't set because it's forced on for
the test. I'll remove it, thanks.