Re: [PATCH] AFS: Implement file locking

J. Bruce Fields
2007-05-29T20:08:28Z

On Tue, May 29, 2007 at 10:34:41AM +0100, David Howells wrote:
> I'll need to test the upgrade/downgrade case. I don't know whether the AFS
> server supports that. If it doesn't, I can emulate downgrade, but not upgrade
> - not unless I only ever ask it for exclusive locks.
>
> Lock upgrading is really, really easy to contrive deadlock for.

Any such deadlock is the user's fault.

But, right, I agree that upgrades are probably hard to use correctly.
And that implementing them shouldn't be a priority in the case of AFS.
Just as long as the implementation doesn't completely fall over when
somebody attempts an upgrade.

--b.