From: David Howells <dhowells@redhat.com>
To: James Morris <jmorris@namei.org>
Cc: dhowells@redhat.com, torvalds@osdl.org,
akpm@linux-foundation.org, serue@us.ibm.com,
linux-kernel@vger.kernel.org,
linux-security-module@vger.kernel.org
Subject: Re: [PATCH 4/6] KEYS: Add garbage collection for dead, revoked and expired keys. [ver #2]
Date: Wed, 05 Aug 2009 10:40:44 +0100 [thread overview]
Message-ID: <28655.1249465244@redhat.com> (raw)
In-Reply-To: <alpine.LRH.2.00.0908051028100.29562@tundra.namei.org>
James Morris <jmorris@namei.org> wrote:
> > + if (now >= gc_at) {
>
> Should you be using time_after() and friends for these comparisons?
Ummm... Possibly. Isn't time_after() normally used for jiffies comparisons?
David
next prev parent reply other threads:[~2009-08-05 9:42 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-04 20:39 [PATCH 1/6] KEYS: Deal with dead-type keys appropriately [ver #2] David Howells
2009-08-04 20:39 ` [PATCH 2/6] KEYS: Allow keyctl_revoke() on keys that have SETATTR but not WRITE perm " David Howells
2009-08-04 20:39 ` [PATCH 3/6] KEYS: Flag dead keys to induce EKEYREVOKED " David Howells
2009-08-04 20:39 ` [PATCH 4/6] KEYS: Add garbage collection for dead, revoked and expired keys. " David Howells
2009-08-04 23:39 ` Serge E. Hallyn
2009-08-05 0:29 ` James Morris
2009-08-05 9:40 ` David Howells [this message]
2009-08-04 20:39 ` [PATCH 5/6] KEYS: Make /proc/keys use keyid not numread as file position " David Howells
2009-08-05 22:59 ` James Morris
2009-08-04 20:39 ` [PATCH 6/6] KEYS: Do some whitespace cleanups " David Howells
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=28655.1249465244@redhat.com \
--to=dhowells@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=jmorris@namei.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=serue@us.ibm.com \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox