From: "Liang, Kan" <kan.liang@linux.intel.com>
To: Leo Yan <leo.yan@linaro.org>
Cc: acme@kernel.org, irogers@google.com, peterz@infradead.org,
mingo@redhat.com, namhyung@kernel.org, jolsa@kernel.org,
adrian.hunter@intel.com, john.g.garry@oracle.com,
will@kernel.org, james.clark@arm.com, mike.leach@linaro.org,
yuhaixin.yhx@linux.alibaba.com, renyu.zj@linux.alibaba.com,
tmricht@linux.ibm.com, ravi.bangoria@amd.com,
linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH V2 4/5] perf mem: Clean up perf_mem_event__supported()
Date: Mon, 11 Dec 2023 13:44:54 -0500 [thread overview]
Message-ID: <2865c1b4-a003-44df-a734-1e1c90bfa14d@linux.intel.com> (raw)
In-Reply-To: <20231209061723.GC2116834@leoy-yangtze.lan>
On 2023-12-09 1:17 a.m., Leo Yan wrote:
> On Thu, Dec 07, 2023 at 11:23:37AM -0800, kan.liang@linux.intel.com wrote:
>> From: Kan Liang <kan.liang@linux.intel.com>
>>
>> For some ARCHs, e.g., ARM and AMD, to get the availability of the
>> mem-events, perf checks the existence of a specific PMU. For the other
>> ARCHs, e.g., Intel and Power, perf has to check the existence of some
>> specific events.
>>
>> The current perf only iterates the mem-events-supported PMUs. It's not
>> required to check the existence of a specific PMU anymore.
>
> With this change, both Arm and AMD archs have no chance to detect if the
> hardware (or the device driver) is supported and the tool will always
> take the memory events are exited on the system, right?
Currently, the Arm and AMD only check the specific PMU. If the PMU is
detected, the memory events are supported. The patch set doesn't change
it. It just moves the check to perf_pmu__arch_init(). When the specific
PMU is initialized, the mem_events is assigned. You don't need to do
runtime sysfs check. It should be an improvement for ARM and AMD.
Thanks,
Kan
>
> Thanks,
> Leo
>
next prev parent reply other threads:[~2023-12-11 18:45 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-07 19:23 [PATCH V2 0/5] Clean up perf mem kan.liang
2023-12-07 19:23 ` [PATCH V2 1/5] perf mem: Add mem_events into the supported perf_pmu kan.liang
2023-12-08 10:29 ` Leo Yan
2023-12-08 18:14 ` Liang, Kan
2023-12-09 6:34 ` Leo Yan
2023-12-11 19:01 ` Liang, Kan
2023-12-13 14:24 ` Leo Yan
2023-12-13 16:19 ` Liang, Kan
2023-12-07 19:23 ` [PATCH V2 2/5] perf mem: Clean up perf_mem_events__ptr() kan.liang
2023-12-09 4:31 ` Leo Yan
2023-12-11 18:09 ` Liang, Kan
2023-12-07 19:23 ` [PATCH V2 3/5] perf mem: Clean up perf_mem_events__name() kan.liang
2023-12-08 0:01 ` Ian Rogers
2023-12-09 5:48 ` Leo Yan
2023-12-11 18:39 ` Liang, Kan
2023-12-13 13:33 ` Leo Yan
2023-12-13 16:17 ` Liang, Kan
2023-12-13 17:33 ` Ian Rogers
2023-12-18 3:21 ` Leo Yan
2023-12-07 19:23 ` [PATCH V2 4/5] perf mem: Clean up perf_mem_event__supported() kan.liang
2023-12-09 6:17 ` Leo Yan
2023-12-11 18:44 ` Liang, Kan [this message]
2023-12-13 13:51 ` Leo Yan
2023-12-13 13:55 ` Ravi Bangoria
2023-12-07 19:23 ` [PATCH V2 5/5] perf mem: Clean up is_mem_loads_aux_event() kan.liang
2023-12-09 6:27 ` Leo Yan
2023-12-11 18:45 ` Liang, Kan
2023-12-07 20:31 ` [PATCH V2 0/5] Clean up perf mem Arnaldo Carvalho de Melo
2023-12-13 9:51 ` Athira Rajeev
2023-12-13 19:54 ` Liang, Kan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2865c1b4-a003-44df-a734-1e1c90bfa14d@linux.intel.com \
--to=kan.liang@linux.intel.com \
--cc=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=irogers@google.com \
--cc=james.clark@arm.com \
--cc=john.g.garry@oracle.com \
--cc=jolsa@kernel.org \
--cc=leo.yan@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mike.leach@linaro.org \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
--cc=ravi.bangoria@amd.com \
--cc=renyu.zj@linux.alibaba.com \
--cc=tmricht@linux.ibm.com \
--cc=will@kernel.org \
--cc=yuhaixin.yhx@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox