From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1425788AbcBRJGy (ORCPT ); Thu, 18 Feb 2016 04:06:54 -0500 Received: from mout.kundenserver.de ([212.227.17.13]:62862 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1425595AbcBRJGs (ORCPT ); Thu, 18 Feb 2016 04:06:48 -0500 From: Arnd Bergmann To: Krzysztof Kozlowski Cc: Sangbeom Kim , Liam Girdwood , Mark Brown , linux-kernel@vger.kernel.org, linux-samsung-soc@vger.kernel.org, jacob.e.keller@intel.com Subject: Re: [PATCH v2] regulator: s2mps11: Simplify expression used in BUILD_BUG_ON Date: Thu, 18 Feb 2016 10:06:28 +0100 Message-ID: <2870104.0q2mccK2EB@wuerfel> User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; ) In-Reply-To: <1455755707-16844-1-git-send-email-k.kozlowski@samsung.com> References: <1455755707-16844-1-git-send-email-k.kozlowski@samsung.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V03:K0:3OEri/v5gLYxTihtShBc7NgWgVzzdyAJ0/mf6dpQz3DCn24GF05 3MjLen52kIOQWJBLAizbk1X6eqjIXitgPP5EVt3vIxXAm0BpG5+Ltaggj7zgApdinLqm4Tt rWEZKQ9zBGU0TOyWTeTwvQIcrCs82KKXkhNkLiohdKXzWLFBNFZJguwcOmxolgGvrdCJ5He notdbCeaZvkAarN4mfR2g== X-UI-Out-Filterresults: notjunk:1;V01:K0:yZRIrhjbc4o=:8RJoe0t1v7x9nMxi+h1G3v QCM8uM16bdBjo/j0w7QiJDjbfPQNnuZ5yxTBOBg9dhvqIQ3mDAJmuRvtCdABgJug++f9ha0mG sG3Jhf+ZIFu98+5TafkvbqSMUpeaY0NxpEgOcBBKWIaz8gAKrBtsS+DQo8/rfMAAOFiyItj5s KLM+NJFhBCDOu2ZCqWz0piBscvER/Yw48ovdsLUOpZo0E4S2KO2crB5ETKUxM+BEvaPyWrICg PrAL7x0SYLJaVhrWIB9dc+BHiCU+2W2axSmpocy9zSQhZYFfyP+7Z2lrgAagDD4NVJ/eFJe5e di00h6xx25b8k74Jc2Bv/+ZxNmeNo2DVKlq1yf1v2elwhtPy63rVTCqvOX1A5ao7419w9HZos rhxp4oJKsYw3wwrwE9E3NrGtSeslwy3Kbx6Qqj9UGEcfjOKG5P3rSmyuALfdSt0cifeGPYhRs 4ibsq2RxehTwILasH/OKn4nfcBtpNopHR4SitkDFxqr8v0TtOeGeT7c19kpn5faM6wVs5br52 E3tRnmkekUFpC/8l+/h0DIQMKf9AW4ykXwIbktCg+ai2lGHSST0RqLmWRDEJMb1GOCLH2I9/b UXC7SFCvFQMb9x+0ojG16yF03TzsSRmnSA/FB0Y8W2oRD/4bjmNHvh1cSLotqi1RSvsUJycR9 itQ7PZ9KhcKS90TgXnDNYCrzr8woQihKkd0YcrNACmwsS6rCsyjpDxyPnQARkPT52gPJ1q9Ps TbByxvDSz7qW8lL+ Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thursday 18 February 2016 09:35:07 Krzysztof Kozlowski wrote: > Following BUILD_BUG_ON using a variable fails for some of the compilers > and optimization levels (reported for gcc 4.9): > var = ARRAY_SIZE(s2mps15_regulators); > BUILD_BUG_ON(S2MPS_REGULATOR_MAX < var); > Fix this by using ARRAY_SIZE directly. > > Additionally add missing BUILD_BUG_ON check for S2MPS15 device (the > check ensures that internal arrays are big enough to hold data for all > of regulators on all devices). > > Reported-by: Arnd Bergmann > Signed-off-by: Krzysztof Kozlowski I've verified that this is the exact patch I have successfully tested on locally and in Olof's autobuilder which reported the problem. > case S2MPS15X: > s2mps11->rdev_num = ARRAY_SIZE(s2mps15_regulators); > regulators = s2mps15_regulators; > + BUILD_BUG_ON(S2MPS_REGULATOR_MAX < ARRAY_SIZE(s2mps15_regulators)); > break; > My version did not add this line, but it seems correct. Tested-by: Arnd Bergmann Reviewed-by: Arnd Bergmann