public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: "Martin J. Bligh" <Martin.Bligh@us.ibm.com>
To: Adrian Bunk <bunk@fs.tum.de>, Dave Jones <davej@suse.de>,
	Brian Gerst <bgerst@didntduck.org>
Cc: linux-kernel@vger.kernel.org
Subject: Re: 2.5.14-dj1: misc.o: undefined reference to `__io_virt_debug'
Date: Tue, 07 May 2002 17:14:19 -0700	[thread overview]
Message-ID: <287160000.1020816859@flay> (raw)
In-Reply-To: <283120000.1020814945@flay>

>>> Compiling misc.c with -O0 gives a better error message:
>>> 
>>> <--  snip  -->
>>> 
>>> ...
>>> ld -m elf_i386 -Ttext 0x100000 -e startup_32 -o bvmlinux head.o misc.o
>>> piggy.o
>>> misc.o: In function `outb_quad':
>>> misc.o(.text+0x289c): undefined reference to `__io_virt_debug'
>>> make[2]: *** [bvmlinux] Error 1
>>> make[2]: Leaving directory
>>> `/home/bunk/linux/kernel-2.5/linux-2.5.14-modular/arch/i386/boot/compressed'
>> 
>> Seems like you're not linking in lib/iodebug.c for some reason.
>> 
>> outb_quad calls readb, which calls __io_virt, which calls __io_virt_debug,
>> which is defined in iodebug.c
> 
> Does this fix it ? (completely untested, and against an old version ... sorry).

There was a typo in this between outb_p_local and outb_local_p inconsistency
fixed below:

--- virgin-2.5.9-dj1/arch/i386/boot/compressed/misc.c	Mon Apr 22 15:29:26 2002
+++ virgin-2.5.9-dj1/arch/i386/boot/compressed/misc.c.local	Tue May  7 16:39:39 2002
@@ -202,10 +202,10 @@
 	SCREEN_INFO.orig_y = y;
 
 	pos = (x + cols * y) * 2;	/* Update cursor position */
-	outb_p(14, vidport);
-	outb_p(0xff & (pos >> 9), vidport+1);
-	outb_p(15, vidport);
-	outb_p(0xff & (pos >> 1), vidport+1);
+	outb_local_p(14, vidport);
+	outb_local_p(0xff & (pos >> 9), vidport+1);
+	outb_local_p(15, vidport);
+	outb_local_p(0xff & (pos >> 1), vidport+1);
 }
 
 static void* memset(void* s, int c, size_t n)
--- virgin-2.5.9-dj1/include/asm-i386/io.h	Tue Apr 23 14:19:39 2002
+++ virgin-2.5.9-dj1/include/asm-i386/io.h.local	Tue May  7 16:38:56 2002
@@ -371,6 +371,15 @@
 	__asm__ __volatile__("in" #bwl " %w1, %" #bw "0" : "=a"(value) : "Nd"(port)); \
 	return value; \
 } \
+static inline void out##bwl##_local_p(unsigned type value, int port) { \
+	out##bwl##_local(value, port); \
+	slow_down_io(); \
+} \
+static inline unsigned type in##bwl##_local_p(int port) { \
+	unsigned type value = in##bwl##_local(port); \
+	slow_down_io(); \
+	return value; \
+} \
 __BUILDIO(bwl,bw,type) \
 static inline void out##bwl##_p(unsigned type value, int port) { \
 	out##bwl(value, port); \


  reply	other threads:[~2002-05-07 23:18 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-05-07 18:36 2.5.14-dj1: misc.o: undefined reference to `__io_virt_debug' Adrian Bunk
2002-05-07 18:48 ` Adrian Bunk
2002-05-07 18:55 ` Dave Jones
2002-05-07 19:44   ` Adrian Bunk
2002-05-07 20:18     ` Dave Jones
2002-05-07 20:57       ` Dave Jones
2002-05-07 22:40     ` Martin J. Bligh
2002-05-07 21:48       ` Brian Gerst
2002-05-07 23:00         ` Martin J. Bligh
2002-05-07 22:43           ` Brian Gerst
2002-05-08  0:12             ` Martin J. Bligh
2002-05-07 21:50       ` Dave Jones
2002-05-07 23:42       ` Martin J. Bligh
2002-05-08  0:14         ` Martin J. Bligh [this message]
2002-06-16 11:19           ` Adrian Bunk
2002-06-23 14:45             ` Martin J. Bligh

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=287160000.1020816859@flay \
    --to=martin.bligh@us.ibm.com \
    --cc=bgerst@didntduck.org \
    --cc=bunk@fs.tum.de \
    --cc=davej@suse.de \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox