public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Richard Weinberger <richard@nod.at>
To: Arushi Singhal <arushisinghal19971997@gmail.com>
Cc: boris.brezillon@free-electrons.com,
	David Woodhouse <dwmw2@infradead.org>,
	Brian Norris <computersforpeace@gmail.com>,
	Marek Vasut <marek.vasut@gmail.com>,
	Cyrille Pitchen <cyrille.pitchen@wedev4u.fr>,
	linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org,
	outreachy-kernel@googlegroups.com
Subject: [Outreachy kernel] Re: [PATCH] mtd: nand: Added spaces around ('=' and '<')
Date: Mon, 05 Mar 2018 16:42:03 +0100	[thread overview]
Message-ID: <2872216.aoWXzO2rYL@blindfold> (raw)
In-Reply-To: <20180303140233.GA9634@seema-Inspiron-15-3567>

Arushi Singhal,

Am Samstag, 3. März 2018, 15:02:33 CET schrieb Arushi Singhal:
> Add spaces around ('=' and '<'),  to conform to the Linux
> kernel coding style. Issue found using checkpatch.

please fix real issues. Coding style fixes to existing code just add too much 
churn. Except for drivers/staging/.

If you're looking for a small MTD related project, I can offer the following.
Cleanup all ubi_assert()s in drivers/mtd/ubi/.
Some of them need to be transformed into a meaningful warning/error message, 
others into a hard error, such as WARN_ON().
Review/understand every ubi_assert() and convert it.

Thanks,
//richard 

-- 
You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
To post to this group, send email to outreachy-kernel@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/2872216.aoWXzO2rYL%40blindfold.
For more options, visit https://groups.google.com/d/optout.

  reply	other threads:[~2018-03-05 15:42 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-03 14:02 [Outreachy kernel] [PATCH] mtd: nand: Added spaces around ('=' and '<') Arushi Singhal
2018-03-05 15:42 ` Richard Weinberger [this message]
2018-03-07 15:38   ` [Outreachy kernel] " Arushi Singhal
2018-03-07 22:03     ` Richard Weinberger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2872216.aoWXzO2rYL@blindfold \
    --to=richard@nod.at \
    --cc=arushisinghal19971997@gmail.com \
    --cc=boris.brezillon@free-electrons.com \
    --cc=computersforpeace@gmail.com \
    --cc=cyrille.pitchen@wedev4u.fr \
    --cc=dwmw2@infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=marek.vasut@gmail.com \
    --cc=outreachy-kernel@googlegroups.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox