From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751384AbYE1NNN (ORCPT ); Wed, 28 May 2008 09:13:13 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1750760AbYE1NNB (ORCPT ); Wed, 28 May 2008 09:13:01 -0400 Received: from mx1.redhat.com ([66.187.233.31]:53542 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750809AbYE1NNA (ORCPT ); Wed, 28 May 2008 09:13:00 -0400 Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: References: To: Pekka J Enberg Cc: dhowells@redhat.com, clameter@sgi.com, mpm@selenic.com, lethal@linux-sh.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] nommu: fix kobjsize() for SLOB and SLUB X-Mailer: MH-E 8.0.3+cvs; nmh 1.2-20070115cvs; GNU Emacs 23.0.50 Date: Wed, 28 May 2008 14:12:35 +0100 Message-ID: <2874.1211980355@redhat.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Pekka J Enberg wrote: > From: Christoph Lameter > > As reported by Paul Mundt, kobjsize() does not work properly with SLOB and SLUB > that re-use parts of struct page for their own purposes. Fix it up by using > compound_order() for compound pages that don't have PageSlab set. > > Reported-by: Paul Mundt > Cc: Christoph Lameter > Signed-off-by: Pekka Enberg > --- > I kept the original object size calculation for non-compound pages in this > version. It looks like the nommu code uses kobjsize() for all sorts of > interesting things. Works for SLAB and SLUB. SLOB breaks well before getting to anything these patches affect. Acked-by: David Howells