From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id DAA7FC6FD1F for ; Wed, 22 Mar 2023 19:09:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229833AbjCVTJc (ORCPT ); Wed, 22 Mar 2023 15:09:32 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54500 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229732AbjCVTJa (ORCPT ); Wed, 22 Mar 2023 15:09:30 -0400 Received: from out30-118.freemail.mail.aliyun.com (out30-118.freemail.mail.aliyun.com [115.124.30.118]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 395FA54CA0 for ; Wed, 22 Mar 2023 12:09:29 -0700 (PDT) X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R161e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=ay29a033018046060;MF=hsiangkao@linux.alibaba.com;NM=1;PH=DS;RN=10;SR=0;TI=SMTPD_---0VeRUxgh_1679512164; Received: from 30.13.187.145(mailfrom:hsiangkao@linux.alibaba.com fp:SMTPD_---0VeRUxgh_1679512164) by smtp.aliyun-inc.com; Thu, 23 Mar 2023 03:09:26 +0800 Message-ID: <287798df-2da6-0158-cbdc-616e587e58bd@linux.alibaba.com> Date: Thu, 23 Mar 2023 03:09:24 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH v3 03/10] erofs: convert to kobject_del_and_put() To: Yangtao Li , Gao Xiang , Chao Yu , Yue Hu , Jeffle Xu Cc: Greg Kroah-Hartman , "Rafael J. Wysocki" , Damien Le Moal , linux-erofs@lists.ozlabs.org, linux-kernel@vger.kernel.org References: <20230322165905.55389-1-frank.li@vivo.com> <20230322165905.55389-2-frank.li@vivo.com> From: Gao Xiang In-Reply-To: <20230322165905.55389-2-frank.li@vivo.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2023/3/23 00:58, Yangtao Li wrote: > Use kobject_del_and_put() to simplify code. > > Cc: Greg Kroah-Hartman > Cc: "Rafael J. Wysocki" > Cc: Damien Le Moal > Signed-off-by: Yangtao Li Acked-by: Gao Xiang Thanks, Gao Xiang > --- > fs/erofs/sysfs.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/fs/erofs/sysfs.c b/fs/erofs/sysfs.c > index 435e515c0792..9ed7d6552155 100644 > --- a/fs/erofs/sysfs.c > +++ b/fs/erofs/sysfs.c > @@ -241,8 +241,7 @@ void erofs_unregister_sysfs(struct super_block *sb) > struct erofs_sb_info *sbi = EROFS_SB(sb); > > if (sbi->s_kobj.state_in_sysfs) { > - kobject_del(&sbi->s_kobj); > - kobject_put(&sbi->s_kobj); > + kobject_del_and_put(&sbi->s_kobj); > wait_for_completion(&sbi->s_kobj_unregister); > } > }