From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 90480C433DB for ; Mon, 4 Jan 2021 13:57:34 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5BAE721D93 for ; Mon, 4 Jan 2021 13:57:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726829AbhADN5e (ORCPT ); Mon, 4 Jan 2021 08:57:34 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54764 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725830AbhADN5d (ORCPT ); Mon, 4 Jan 2021 08:57:33 -0500 Received: from mail-wr1-x435.google.com (mail-wr1-x435.google.com [IPv6:2a00:1450:4864:20::435]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7F866C061574; Mon, 4 Jan 2021 05:56:52 -0800 (PST) Received: by mail-wr1-x435.google.com with SMTP id m5so32206904wrx.9; Mon, 04 Jan 2021 05:56:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding:content-language; bh=LyrRUhBkoqWcAGCYsSDBZgPQ6OfRjVUqBOc3wjEtEV8=; b=peukgvMHKbc4pR8s8RYGql7/y3W5Zj3+lzKdEHPUnq/2rthPuY+XlF/7wfDu35DLAO 4oZQdkJ+kNUNNCGUD0tS37DTvWqFrRs+bWzt8/1xQlGWzD/e0NU++DskCK2qw2+LcjAl PJeUWfGYPuTI23iTUYN2OieUZj2b/SqcZvLm+PYpK2BROpvvKDpaE0heezIxHQIlPDS3 iykoSUMAAuDxIq3ua2CuwrTP499STfiOqC2yUVbwLMrbU7jqSKoAbNZ73OE+kQTmPmob oM96pSAWbunUPlhga4J70SugNYdWLhVDMlqQYfjLuXr1P+2Z3WLb9hYS7tXNQN5uoIpz P+rA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=LyrRUhBkoqWcAGCYsSDBZgPQ6OfRjVUqBOc3wjEtEV8=; b=o0rRkiVbYEgKROQkuU2fsOSPya/RxinYKp5U6/IGH2dv6GMjVLGUQ68J+TTMYNoKa7 lN/aWMGKiFeoAo0jc3clu+HmYtzRW8zdWW4vQn6/luthffE/rDdpBqCeyrKwLUHzt0Wb slDntIYrCbvNQXqcKfbJ0Dchk22zwG41kPA+I4vxPZb4JphGmk4jq+2JU8I1edHeAhtM YLIBQEURSWDmm2UbOdfnClENE5GeOJtB/TrfqKAgNoB4q6RzcEexliSHI0Vjjic4mcDY Ltdk3xjd0yTZn671RB4uFzvSeiTCUWCP/g0AP3+hmVI6Jtj+wMpKhoo19HEk1VjdsKyR Okbg== X-Gm-Message-State: AOAM531srO/Xm7Y+zPM2/21kl9/mC6K2jGNYZeK2ks4oorjqYQ1EXZR0 eQETReWhIJVKhjKsDUaeIBs= X-Google-Smtp-Source: ABdhPJwpb88Cfo7Gp8j6dnF/Hw5fgGdPfsTA6M6ICjCrC6rfVw9+Y7Gog2Pg6F2shHFem2EIlh7Zig== X-Received: by 2002:adf:e9d2:: with SMTP id l18mr77835390wrn.179.1609768611288; Mon, 04 Jan 2021 05:56:51 -0800 (PST) Received: from [192.168.1.211] ([2.29.208.120]) by smtp.gmail.com with ESMTPSA id b12sm48311878wmj.2.2021.01.04.05.56.49 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 04 Jan 2021 05:56:50 -0800 (PST) Subject: Re: [PATCH v4 15/15] ipu3-cio2: Add cio2-bridge to ipu3-cio2 driver To: Andy Shevchenko , Joe Perches Cc: Andy Shevchenko , Linux Kernel Mailing List , ACPI Devel Maling List , Linux Media Mailing List , devel@acpica.org, Greg Kroah-Hartman , "Rafael J. Wysocki" , Sergey Senozhatsky , Mauro Carvalho Chehab , Len Brown , Yong Zhi , Sakari Ailus , Bingbu Cao , Tian Shu Qiu , Robert Moore , Erik Kaneda , Petr Mladek , Steven Rostedt , Rasmus Villemoes , Laurent Pinchart , Jacopo Mondi , kieran.bingham+renesas@ideasonboard.com, Hans Verkuil , Marco Felsch , niklas.soderlund+renesas@ragnatech.se, Steve Longerbeam , "Krogerus, Heikki" , Linus Walleij , Jordan Hand , Laurent Pinchart References: <20210103231235.792999-1-djrscally@gmail.com> <20210103231235.792999-16-djrscally@gmail.com> <20210104120905.GR4077@smile.fi.intel.com> <2f64873d-0413-3614-34e2-139b4a4d9da6@gmail.com> From: Daniel Scally Message-ID: <287cf1cc-0e96-7609-aecd-e00dedcd90d9@gmail.com> Date: Mon, 4 Jan 2021 13:56:49 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Content-Language: en-US Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 04/01/2021 13:38, Andy Shevchenko wrote: > On Mon, Jan 4, 2021 at 3:02 PM Daniel Scally wrote: >> On 04/01/2021 12:09, Andy Shevchenko wrote: >>> On Sun, Jan 03, 2021 at 11:12:35PM +0000, Daniel Scally wrote: > ... > >>>> +#define NODE_SENSOR(_HID, _PROPS) \ >>>> + ((const struct software_node) { \ >>>> + .name = _HID, \ >>>> + .properties = _PROPS, \ >>>> + }) >>>> + >>>> +#define NODE_PORT(_PORT, _SENSOR_NODE) \ >>>> + ((const struct software_node) { \ >>>> + .name = _PORT, \ >>>> + .parent = _SENSOR_NODE, \ >>>> + }) >>>> + >>>> +#define NODE_ENDPOINT(_EP, _PORT, _PROPS) \ >>>> + ((const struct software_node) { \ >>>> + .name = _EP, \ >>>> + .parent = _PORT, \ >>>> + .properties = _PROPS, \ >>>> + }) >>> In all three I didn't get why you need outer parentheses. Without them it will >>> be well defined compound literal and should work as is. >> The code works fine, but checkpatch complains that macros with complex >> values should be enclosed in parentheses. I guess now that I'm more >> familiar with the code I'd call that a false-positive though, as nowhere >> else in the kernel that I've seen encloses them the same way. > I guess it is yet another false positive from checkpatch. > I would ignore its complaints. Will do so then