From: David Howells <dhowells@redhat.com>
To: Dan Carpenter <error27@gmail.com>
Cc: dhowells@redhat.com, kernel-janitors@vger.kernel.org,
linux-afs@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [patch] afs: potential null dereference
Date: Mon, 22 Mar 2010 12:05:20 +0000 [thread overview]
Message-ID: <28809.1269259520@redhat.com> (raw)
In-Reply-To: <20100320111938.GT5331@bicker>
Dan Carpenter <error27@gmail.com> wrote:
> It seems clear from the surrounding code that xpermits is allowed to be
> NULL here.
Interesting. The memcpy() won't oops due to this because if it is given a
NULL pointer, it will also be given a zero count. I wonder if this means the
if-statement your patch adds is actually unnecessary...
David
next prev parent reply other threads:[~2010-03-22 12:05 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-20 11:19 [patch] afs: potential null dereference Dan Carpenter
2010-03-22 12:05 ` David Howells [this message]
2010-03-22 12:56 ` Dan Carpenter
2010-03-22 13:05 ` David Howells
-- strict thread matches above, loose matches on Subject: below --
2010-03-22 13:07 [PATCH] AFS: Potential " David Howells
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=28809.1269259520@redhat.com \
--to=dhowells@redhat.com \
--cc=error27@gmail.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-afs@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox