From: Arnd Bergmann <arnd@arndb.de>
To: broonie@kernel.org
Cc: Brian Austin <brian.austin@cirrus.com>,
Paul Handrigan <Paul.Handrigan@cirrus.com>,
Liam Girdwood <lgirdwood@gmail.com>,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ASoC: cs35l32: avoid uninitialized variable access
Date: Sat, 02 Jan 2016 00:19:52 +0100 [thread overview]
Message-ID: <2884997.s8B8BuE04L@wuerfel> (raw)
gcc warns about the possibilty of accessing a property read from
devicetree in cs35l32_i2c_probe() when it has not been initialized
because CONFIG_OF is disabled:
sound/soc/codecs/cs35l32.c: In function 'cs35l32_i2c_probe':
sound/soc/codecs/cs35l32.c:278:2: warning: 'val' may be used uninitialized in this function [-Wmaybe-uninitialized]
The code is actually correct because it checks the dev->of_node
variable first and we know this is NULL here, but by adding a
check for IS_ENABLED(CONFIG_OF), we can let the compiler know
as well, and also generate smaller object code.
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
diff --git a/sound/soc/codecs/cs35l32.c b/sound/soc/codecs/cs35l32.c
index 44c30fe3e315..52ffaa8eb02b 100644
--- a/sound/soc/codecs/cs35l32.c
+++ b/sound/soc/codecs/cs35l32.c
@@ -372,7 +372,7 @@ static int cs35l32_i2c_probe(struct i2c_client *i2c_client,
dev_err(&i2c_client->dev, "could not allocate pdata\n");
return -ENOMEM;
}
- if (i2c_client->dev.of_node) {
+ if (IS_ENABLED(CONFIG_OF) && i2c_client->dev.of_node) {
ret = cs35l32_handle_of_data(i2c_client,
&cs35l32->pdata);
if (ret != 0)
next reply other threads:[~2016-01-01 23:20 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-01 23:19 Arnd Bergmann [this message]
2016-01-02 14:17 ` [PATCH] ASoC: cs35l32: avoid uninitialized variable access Mark Brown
2016-01-04 15:17 ` Arnd Bergmann
2016-01-04 15:20 ` Russell King - ARM Linux
2016-01-04 16:41 ` Arnd Bergmann
2016-01-04 16:52 ` Russell King - ARM Linux
2016-01-04 15:45 ` Mark Brown
-- strict thread matches above, loose matches on Subject: below --
2016-03-07 4:19 Arnd Bergmann
2016-03-07 12:22 ` Austin, Brian
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2884997.s8B8BuE04L@wuerfel \
--to=arnd@arndb.de \
--cc=Paul.Handrigan@cirrus.com \
--cc=brian.austin@cirrus.com \
--cc=broonie@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox