Re: [PATCH 1/6] dt-bindings: mfd: add max77759 binding

Krzysztof Kozlowski
2025-02-24T13:05:32Z

On 24/02/2025 14:02, André Draszik wrote:
> On Mon, 2025-02-24 at 06:48 -0600, Rob Herring (Arm) wrote:
>>
>> On Mon, 24 Feb 2025 10:28:49 +0000, André Draszik wrote:
>>> Add device tree binding for the Maxim MAX77759 companion PMIC for USB
>>> Type-C applications.
>>>
>>> The MAX77759 includes Battery Charger, Fuel Gauge, temperature sensors,
>>> USB Type-C Port Controller (TCPC), NVMEM, and a GPIO expander.
>>>
>>> This describes the core mfd device.
>>>
>>> Signed-off-by: André Draszik <andre.draszik@linaro.org>
>>> ---
>>>  .../devicetree/bindings/mfd/maxim,max77759.yaml    | 104 +++++++++++++++++++++
>>>  MAINTAINERS                                        |   6 ++
>>>  2 files changed, 110 insertions(+)
>>>
>>
>> My bot found errors running 'make dt_binding_check' on your patch:
>>
>> yamllint warnings/errors:
>>
>> dtschema/dtc warnings/errors:
>> /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/mfd/maxim,max77759.example.dtb: pmic@66: gpio: False schema
>> does not allow {'compatible': ['maxim,max77759-gpio'], 'gpio-controller': True, '#gpio-cells': 2, 'interrupt-controller': True,
>> '#interrupt-cells': 2}
>> from schema $id: http://devicetree.org/schemas/mfd/maxim,max77759.yaml#
>> /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/mfd/maxim,max77759.example.dtb: pmic@66: pmic-nvmem: False
>> schema does not allow {'compatible': ['maxim,max77759-nvmem'], 'nvmem-layout': {'compatible': ['fixed-layout'], '#address-cells': 1,
>> '#size-cells': 1, 'reboot-mode@0': {'reg': [[0, 4]]}, 'boot-reason@4': {'reg': [[4, 4]]}, 'shutdown-user-flag@8': {'reg': [[8, 1]]},
>> 'rsoc@10': {'reg': [[10, 2]]}}}
>> from schema $id: http://devicetree.org/schemas/mfd/maxim,max77759.yaml#
>> Documentation/devicetree/bindings/mfd/maxim,max77759.example.dtb: /example-0/i2c/pmic@66/gpio: failed to match any schema with
>> compatible: ['maxim,max77759-gpio']
>> Documentation/devicetree/bindings/mfd/maxim,max77759.example.dtb: /example-0/i2c/pmic@66/pmic-nvmem: failed to match any schema with
>> compatible: ['maxim,max77759-nvmem']
>
> The top-level example in here references the two (MFD cell)
> bindings added in the two follow-up patches for gpio and
> nvmem. When all three binding patches exist in the tree,
> the errors are gone.
>
> Is this acceptable, or shall I add the top-level example only
> after the bindings?

Not sure if I follow - do you confirm that it is bisectable or it is
not? If not, then it has to be fixed.

Best regards,
Krzysztof