From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752214AbcHHMzr (ORCPT ); Mon, 8 Aug 2016 08:55:47 -0400 Received: from cloudserver094114.home.net.pl ([79.96.170.134]:58368 "HELO cloudserver094114.home.net.pl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1752007AbcHHMzq (ORCPT ); Mon, 8 Aug 2016 08:55:46 -0400 From: "Rafael J. Wysocki" To: Peter Zijlstra Cc: Doug Smythies , "'Linux PM list'" , "'Srinivas Pandruvada'" , "'Viresh Kumar'" , "'Linux Kernel Mailing List'" , "'Steve Muckle'" , "'Juri Lelli'" , "'Ingo Molnar'" Subject: Re: [RFC][PATCH 0/7] cpufreq / sched: cpufreq_update_util() flags and iowait boosting Date: Mon, 08 Aug 2016 15:01:04 +0200 Message-ID: <2893698.pXQui9Dkv5@vostro.rjw.lan> User-Agent: KMail/4.11.5 (Linux/4.5.0-rc1+; KDE/4.11.5; x86_64; ; ) In-Reply-To: <20160808110822.GC6879@twins.programming.kicks-ass.net> References: <3752826.3sXAQIvcIA@vostro.rjw.lan> <2815658.F6xEHcjr3t@vostro.rjw.lan> <20160808110822.GC6879@twins.programming.kicks-ass.net> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="utf-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Monday, August 08, 2016 01:08:22 PM Peter Zijlstra wrote: > On Mon, Aug 01, 2016 at 06:30:27PM +0200, Rafael J. Wysocki wrote: > > > CPU_FREQ_GOV_SCHEDUTIL m -> y > > > > ERROR: "runqueues" [kernel/sched/cpufreq_schedutil.ko] undefined! > > > There are some export_symbol declarations missing, I'll fix that up. > > Do you really need that thing to be a module? I would raelly like to not > export runqueues. People have had 'crazy' ideas in the past. It doesn't have to be a module, but it is today. Well, I guess accessing scheduler data directly is a good enough resone for making it non-modular. :-) Thanks, Rafael