From: Keith Owens <kaos@ocs.com.au>
To: Rasmus Andersen <rasmus@jaquet.dk>
Cc: pgmdsg@ibi.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] make riscom8.c build (248p4)
Date: Mon, 06 Aug 2001 05:24:22 +1000 [thread overview]
Message-ID: <28998.997039462@ocs3.ocs-net> (raw)
In-Reply-To: Your message of "Sun, 05 Aug 2001 18:22:08 +0200." <20010805182208.S821@jaquet.dk>
On Sun, 5 Aug 2001 18:22:08 +0200,
Rasmus Andersen <rasmus@jaquet.dk> wrote:
>--- linux-248-pre4-clean/drivers/char/riscom8.c Sun Aug 5 14:34:54 2001
>+++ linux-248p4-kbuild/drivers/char/riscom8.c Sun Aug 5 18:14:29 2001
>@@ -1866,10 +1866,10 @@
> __setup("riscom8=", riscom8_setup);
> #endif
>
>-static const char banner[] __initdata =
>+static char banner[] __initdata =
> KERN_INFO "rc: SDL RISCom/8 card driver v1.1, (c) D.Gorodchanin "
> "1994-1996.\n";
>-static const char no_boards_msg[] __initdata =
>+static char no_boards_msg[] __initdata =
> KERN_INFO "rc: No RISCom/8 boards detected.\n";
>
It is even documented in Documentation/DocBook/kernel-hacking.tmpl that
__initdata cannot be const. Not all versions of gcc flag an error,
newer ones do.
prev parent reply other threads:[~2001-08-05 19:24 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-08-05 16:22 [PATCH] make riscom8.c build (248p4) Rasmus Andersen
2001-08-05 19:24 ` Keith Owens [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=28998.997039462@ocs3.ocs-net \
--to=kaos@ocs.com.au \
--cc=linux-kernel@vger.kernel.org \
--cc=pgmdsg@ibi.com \
--cc=rasmus@jaquet.dk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox