From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Matti Vaittinen <mazziesaccount@gmail.com>,
Matti Vaittinen <matti.vaittinen@fi.rohmeurope.com>
Cc: Jonathan Cameron <jic23@kernel.org>,
Lars-Peter Clausen <lars@metafoo.de>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
linux-iio@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/3] dt-bindings: ROHM BU27010 RGBC + flickering sensor
Date: Wed, 14 Jun 2023 08:36:47 +0200 [thread overview]
Message-ID: <28cba091-48d0-846d-4996-64e71be275f2@linaro.org> (raw)
In-Reply-To: <fac025f6-6187-2258-9d49-61799754294f@gmail.com>
On 14/06/2023 07:32, Matti Vaittinen wrote:
>>> +properties:
>>> + compatible:
>>> + const: rohm,bu27010
>>> +
>>> + reg:
>>> + maxItems: 1
>>> +
>>> + interrupts:
>>> + maxItems: 1
>>> +
>>> + vdd-supply: true
>>
>> Isn't vdd-supply required for the hardware to work? How does it get the
>> power otherwise?
>
> The BU27010 works by magic smoke. When smoke leaks out the sensor no
> longer works.
>
> Ehh, I think you are right. My thinking was that it is not uncommon for
> people to not have all fixed regulators present in device-tree. But I
> agree, this does not mean we should encourage that. I'll add supply to
> the list of the required properties.
>
If the device actually requires a regulator, it should be required by
the bindings, even if it leads to dummies or fixed regulators on the
board DTS.
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-06-14 6:37 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-13 10:04 [PATCH 0/3] Support ROHM BU27010 RGBC sensor Matti Vaittinen
2023-06-13 10:19 ` [PATCH 1/3] dt-bindings: ROHM BU27010 RGBC + flickering sensor Matti Vaittinen
2023-06-13 18:42 ` Krzysztof Kozlowski
2023-06-14 5:32 ` Matti Vaittinen
2023-06-14 6:36 ` Krzysztof Kozlowski [this message]
2023-06-13 10:20 ` [PATCH 2/3] iio: light: bu27008: add chip info Matti Vaittinen
2023-06-17 19:48 ` Jonathan Cameron
2023-06-20 8:03 ` Matti Vaittinen
2023-06-13 10:20 ` [PATCH 3/3] iio: light: bd27008: Support BD27010 RGB Matti Vaittinen
2023-06-17 19:57 ` Jonathan Cameron
2023-06-20 8:06 ` Matti Vaittinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=28cba091-48d0-846d-4996-64e71be275f2@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jic23@kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=matti.vaittinen@fi.rohmeurope.com \
--cc=mazziesaccount@gmail.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox