From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 073382F3C10 for ; Fri, 8 May 2026 10:06:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778234778; cv=none; b=hc68JTnZYnA97Cw+yFcQvTOPxITN+4TID1UUAT4p83Hdw7x1k3Pckt8UNubHSWSX/mndeShGmeKyHPEydIrYyUQwpvIl2RCMkAge58atwJZOeS1LEglxHJJCTC9BXf/1v7PJTZxGkHe0ilLK0biFt0isYzmOuTG5+Y8HQOwZtC4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778234778; c=relaxed/simple; bh=VjEJENxDuHCllJ7KS2xG9VmjlN7BZbjIH3IT1Yto7aQ=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=QfwI9PAjLu020sWtqflv9lowzmHdaQ639BgnyPNDQzkJG9W0w0qvuLQSEoJ8vTGc2OOXHs0PqokM2SQhOHHJjmIFOg2rPKrFArZtuDz6xOqqC5UIxK+3Lb5x+eOCr+0UGcIhirOepMPb6+AlkGCjFtRowFoyi3yy7U7CtwokQ+c= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=lXFTBvDw; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=FvxtNN/d; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="lXFTBvDw"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="FvxtNN/d" Received: from pps.filterd (m0279870.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 6485V1D72198694 for ; Fri, 8 May 2026 10:06:14 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= OayF4gM8TJfL26qUwfDS4uiyjtIujhhqWG9XxC8ev90=; b=lXFTBvDwjEcLfFuD yoinouVC3528ecIKdmh8PZI7aBG57VSdNqoZhaeRe+Vyh8qU4pkkt7Vmk8RMDqXU ioHBlKyWMmfcrg1l5yFvC6MXbzm7L6zwyYw6ifH4e+GtxmTijxPTanNLlpyqjt1a XOUq1UY7nqNevE12p5TeV+cso9E8fOcyU2RQo34zNYFNQMAxfAIrHIeNzHj7dvs0 TflAn2HA0SKBdcQYkOBxgze6xkmdJPfh1+h4PqGWhv31ll6w6VYvmcizgb1Dhw4H U/L+xxEfuRUDtZUqModHR9khA+eGGVOUli8OjKm7Hxk1PlJtwz8s2pEHl9uKyT0E xMvcAA== Received: from mail-vk1-f200.google.com (mail-vk1-f200.google.com [209.85.221.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4e119sjsjc-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 08 May 2026 10:06:14 +0000 (GMT) Received: by mail-vk1-f200.google.com with SMTP id 71dfb90a1353d-5751831fe6dso208212e0c.1 for ; Fri, 08 May 2026 03:06:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1778234773; x=1778839573; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=OayF4gM8TJfL26qUwfDS4uiyjtIujhhqWG9XxC8ev90=; b=FvxtNN/d5edtgd0Jg2G06RH9gpwv9V6vjcc5UOKRBryvidtMD0R5TSNCaZaWKBLAjd mVX4yC0E9djnlKvp2N0Cxexfx2gXTj0JeAmPZimd5XWl1BTX8BX6jC5kwIGn/cJu7R6S yFxKropXG/DfAzP33MhhjZYZavCIpZwq8xbhWbnw4sPqeVnuHTsUUF2nicf6bjahcI3s P/u2GG3ZhTnGKGUPe1PIbNt12FYsTUvIqIIVHs7yWma+M7811MjH24uWJnFWtUTO43Np xT0kpSe4QZxcllve4dEHvuP0HJM0L/np+/ex01Xoa7MQluJg6YbEOfViNkNw2ylFyF0I rnqg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778234773; x=1778839573; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=OayF4gM8TJfL26qUwfDS4uiyjtIujhhqWG9XxC8ev90=; b=PxDmWaRlXF/qxV1ISiIWxUEPNRvZZBJJPVayHgANZ91GeckOvD5eRN8eL9txaMxIfh YdOOUbkIbo+2WZMkNV/cAUiGORIrmMSJ6ox+umQyxUWVfX/20VUCzkM6yJJMxNKbMrfb pCCGLA1D/cOl/8hn1UOBi3v+cQKSWymz/15HloVWBbZnepjzSjwUJBk+rS7UpPFSqDlo JwqY+5KjVwfHiu/Wy88esQxT80OjEG8U2fgg8nwa9bs+AdsG9pvb7UN9omPbSQ3utj1M uRJtQzMCBuUp6VLImlxS+0RPIZ606gwwNvkPA7AczIwKjmkX7t6vpSQ6+XtZ3JlAgSc4 ovIw== X-Forwarded-Encrypted: i=1; AFNElJ/2T9Z0E4BQby0txpbd4i4X+NyL+4VDdUR973PTiJMpnoM8eGEr3r/LN+ChiN1sEn5BFZHnJNBQeu0DqhU=@vger.kernel.org X-Gm-Message-State: AOJu0YwpCiyUlUu5PWI2wC9PcX15eqwGTc5H6p8Y6wdr/+fcZyzupQTu RiB+cYYpc+/P9yoER2dhthUJFHn3RC3jhx1/WlXM9d720UBfOqqgSnKYNJMe9YWsAcC75EomaDf pPDtHvW5gpTRuC0RULTI9l5/ShwKYk54L0iG9crmkCvqFj0CxzS4m5ze2FqEvSXDAlX8= X-Gm-Gg: Acq92OGJvYOL/1MJfWM/RWRAi4+gt+LnYTmUgwcBlAIJiHUwRxFc/G69VWKCPEYFlTe MVvG8DN5irBrpYrlmo4w+Q0qPTZy/8Gl/HqI3zOqzAhshMaMWHryw2VD0XQ0dKq2OTYkpb1SLsF R1Tjkd+n8anqb4q2Vn6CEZxypR0aKDzlMvqbUXz9EPL+hTNr4gdbsGJR1W5SuuyUcqjRykKy7ig 18D9ZHvKN6EYkcflLG8uXsDnUm1rxnkvvUOuM3s+ajrtIN4wjTqrtvMivppqvpRTSpVnyK/KojR 7C91+pZGLbFNy1OZ7S3AI6WS7cpE0q/gABs1wf9y3wsj30Ok6/8xklFFCYLrUZGJucQQBsg4QgT oNO4dmGYj8rChPlEYTva4V+WwzdcbAfCJ9N+wrYtcdK4ePHkSZr+t1ak66xSXa0iSBkQKhxZSqu 64cwcS01kJk+XuSQ== X-Received: by 2002:a05:6122:6214:b0:56d:baee:40 with SMTP id 71dfb90a1353d-5755cc74085mr2309381e0c.1.1778234773413; Fri, 08 May 2026 03:06:13 -0700 (PDT) X-Received: by 2002:a05:6122:6214:b0:56d:baee:40 with SMTP id 71dfb90a1353d-5755cc74085mr2309369e0c.1.1778234773009; Fri, 08 May 2026 03:06:13 -0700 (PDT) Received: from [192.168.119.254] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-bcb43e09752sm21464166b.59.2026.05.08.03.06.10 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 08 May 2026 03:06:12 -0700 (PDT) Message-ID: <28dd74fb-ebdc-438c-8624-6b8fa0657e40@oss.qualcomm.com> Date: Fri, 8 May 2026 12:06:09 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 19/29] drm/msm/adreno: use version ranges in A8xx UBWC code To: Dmitry Baryshkov , Rob Clark , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Sean Paul , Marijn Suijten , David Airlie , Simona Vetter , Bjorn Andersson , Konrad Dybcio , Akhil P Oommen Cc: linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org References: <20260507-ubwc-rework-v4-0-c19593d20c1d@oss.qualcomm.com> <20260507-ubwc-rework-v4-19-c19593d20c1d@oss.qualcomm.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20260507-ubwc-rework-v4-19-c19593d20c1d@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNTA4MDEwMyBTYWx0ZWRfX5UmuATY/RLup Xd1Wo4lNeC0zmDMuq6WzKPG9D785ajsE7LaMrsZrMgTXdEtEhrExKFUTRxsgjEL1qOb1BxqeoTD +ft8ejd1lViPXGq95zXv8P8n9WYH6JoVcYh0s/43QsB0HFKUrbiVo9ZS9DoUZE76Tyo+96eOBRL cc773Lm/fk4GIyfs1lA/+eRB0ghyA17GtCXjWNDjIYPv4SMQ8wG81a+3EB3KCIAK1mLrmhZgVKE ltmnhy3d6dc5OxYH4pyeCttow0PplM1yNlrP175e+VlnHQZAyNZkRf4X2EVlnWQlahCo8iOVD0B jD8iufboPfWeacZYWLg+cB+x8jlHe1qTkWubDUITQDa8oau9K9z/aOhohGY2BLtOzOkILQXE/wU w/IwHR7idPdcBsGrPOCPLGYT/s/R0p8AE4J68BO3bdioYPF/h4nWpe8UeVsL03xRXdN65ItDXk6 9bpDl0iLjrFeWaObmNQ== X-Proofpoint-ORIG-GUID: HrFZ5x3CVjhhBRFyGv9jCXwKO29k_8fY X-Proofpoint-GUID: HrFZ5x3CVjhhBRFyGv9jCXwKO29k_8fY X-Authority-Analysis: v=2.4 cv=Dd4nbPtW c=1 sm=1 tr=0 ts=69fdb596 cx=c_pps a=wuOIiItHwq1biOnFUQQHKA==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=NGcC8JguVDcA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=gowsoOTTUOVcmtlkKump:22 a=EUspDBNiAAAA:8 a=F66dyu4Cpv24ktMMw0UA:9 a=QEXdDO2ut3YA:10 a=XD7yVLdPMpWraOa8Un9W:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-05-07_02,2026-05-06_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 bulkscore=0 clxscore=1015 adultscore=0 lowpriorityscore=0 suspectscore=0 spamscore=0 impostorscore=0 phishscore=0 priorityscore=1501 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2604200000 definitions=main-2605080103 On 5/7/26 3:03 PM, Dmitry Baryshkov wrote: > In order to simplify handling of UBWC minor revisions (like 3.1 or 4.3) > use version ranges instead of a case switch. > > Signed-off-by: Dmitry Baryshkov > --- > drivers/gpu/drm/msm/adreno/a8xx_gpu.c | 32 +++++++++++++++----------------- > 1 file changed, 15 insertions(+), 17 deletions(-) > > diff --git a/drivers/gpu/drm/msm/adreno/a8xx_gpu.c b/drivers/gpu/drm/msm/adreno/a8xx_gpu.c > index 5c73a9ebb22b..29d559fe4683 100644 > --- a/drivers/gpu/drm/msm/adreno/a8xx_gpu.c > +++ b/drivers/gpu/drm/msm/adreno/a8xx_gpu.c > @@ -286,26 +286,24 @@ static void a8xx_set_ubwc_config(struct msm_gpu *gpu) > u32 hbb, hbb_hi, hbb_lo, mode; > u8 uavflagprd_inv = 2; > > - switch (ubwc_version) { > - case UBWC_6_0: > + if (ubwc_version > UBWC_6_0) > + dev_err(&gpu->pdev->dev, "Unknown UBWC version: 0x%x\n", ubwc_version); > + > + if (ubwc_version == UBWC_6_0) > yuvnotcomptofc = true; > - rgb565_predicator = true; > - break; > - case UBWC_5_0: > - rgb565_predicator = true; > - break; > - case UBWC_4_0: > - rgb565_predicator = true; > - fp16compoptdis = true; > + > + if (ubwc_version < UBWC_5_0 && > + ubwc_version >= UBWC_4_0) > rgba8888_lossless = true; > - break; > - case UBWC_3_0: > + > + if (ubwc_version < UBWC_4_3) < 4.3 specifically, or if (4.x)? Konrad