From: "Jernej Škrabec" <jernej.skrabec@gmail.com>
To: Lee Jones <lee@kernel.org>, Chen-Yu Tsai <wens@csie.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Andre Przywara <andre.przywara@arm.com>
Cc: Icenowy Zheng <uwu@icenowy.me>, Mark Brown <broonie@kernel.org>,
Samuel Holland <samuel@sholland.org>,
Shengyu Qu <wiagn233@outlook.com>,
Martin Botka <martin.botka1@gmail.com>,
Matthew Croughan <matthew.croughan@nix.how>,
linux-sunxi@lists.linux.dev, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 1/2] dt-bindings: mfd: x-powers,axp152: make interrupt optional for more chips
Date: Sun, 24 Sep 2023 21:50:46 +0200 [thread overview]
Message-ID: <2900712.e9J7NaK4W3@jernej-laptop> (raw)
In-Reply-To: <20230919103913.463156-2-andre.przywara@arm.com>
Dne torek, 19. september 2023 ob 12:39:12 CEST je Andre Przywara napisal(a):
> All X-Powers PMICs described by this binding have an IRQ pin, and so
> far (almost) all boards connected this to some NMI pin or GPIO on the SoC
> they are connected to.
> However we start to see boards that omit this connection, and technically
> the IRQ pin is not essential to the basic PMIC operation.
>
> The existing Linux driver allows skipping the IRQ pin setup for two chips
> already, so update the binding to also make the DT property optional for
> the missing chip. And while we are at it, add the AXP313a to that list,
> as they are actually boards out there not connecting the IRQ pin.
>
> This allows to have DTs correctly describing those boards not wiring up
> the interrupt.
>
> Signed-off-by: Andre Przywara <andre.przywara@arm.com>
> Acked-by: Conor Dooley <conor.dooley@microchip.com>
Should I pick this patch through sunxi tree?
Best regards,
Jernej
> ---
> Documentation/devicetree/bindings/mfd/x-powers,axp152.yaml | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/mfd/x-powers,axp152.yaml b/Documentation/devicetree/bindings/mfd/x-powers,axp152.yaml
> index 9ad55746133b5..06f1779835a1e 100644
> --- a/Documentation/devicetree/bindings/mfd/x-powers,axp152.yaml
> +++ b/Documentation/devicetree/bindings/mfd/x-powers,axp152.yaml
> @@ -67,7 +67,10 @@ allOf:
> properties:
> compatible:
> contains:
> - const: x-powers,axp305
> + enum:
> + - x-powers,axp15060
> + - x-powers,axp305
> + - x-powers,axp313a
>
> then:
> required:
>
next prev parent reply other threads:[~2023-09-24 19:51 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-19 10:39 [PATCH v3 0/2] mfd: axp20x: improve support without interrupts Andre Przywara
2023-09-19 10:39 ` [PATCH v3 1/2] dt-bindings: mfd: x-powers,axp152: make interrupt optional for more chips Andre Przywara
2023-09-24 19:50 ` Jernej Škrabec [this message]
2023-09-25 7:46 ` Lee Jones
2023-09-28 13:46 ` (subset) " Lee Jones
2023-09-19 10:39 ` [PATCH v3 2/2] mfd: axp20x: Generalise handling without interrupt Andre Przywara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2900712.e9J7NaK4W3@jernej-laptop \
--to=jernej.skrabec@gmail.com \
--cc=andre.przywara@arm.com \
--cc=broonie@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lee@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sunxi@lists.linux.dev \
--cc=martin.botka1@gmail.com \
--cc=matthew.croughan@nix.how \
--cc=robh+dt@kernel.org \
--cc=samuel@sholland.org \
--cc=uwu@icenowy.me \
--cc=wens@csie.org \
--cc=wiagn233@outlook.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox