public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Luca Weiss <luca@lucaweiss.eu>
To: Robert Foss <rfoss@kernel.org>, Todor Tomov <todor.too@gmail.com>,
	Bryan O'Donoghue <bryan.odonoghue@linaro.org>,
	Mauro Carvalho Chehab <mchehab@kernel.org>,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Kapatrala Syed <akapatra@quicinc.com>,
	Hariram Purushothaman <hariramp@quicinc.com>,
	cros-qcom-dts-watchers@chromium.org,
	Bjorn Andersson <andersson@kernel.org>,
	Konrad Dybcio <konrad.dybcio@linaro.org>,
	Loic Poulain <loic.poulain@linaro.org>,
	Andi Shyti <andi.shyti@kernel.org>,
	Vikram Sharma <quic_vikramsa@quicinc.com>
Cc: linux-arm-msm@vger.kernel.org, linux-media@vger.kernel.org,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-i2c@vger.kernel.org,
	Vikram Sharma <quic_vikramsa@quicinc.com>,
	Hariram Purushothaman <quic_hariramp@quicinc.com>
Subject: Re: [PATCH 5/6] i2c: Enable IMX577 camera sensor for qcm6490
Date: Sat, 29 Jun 2024 10:22:40 +0200	[thread overview]
Message-ID: <2902343.mvXUDI8C0e@g550jk> (raw)
In-Reply-To: <20240629-camss_first_post_linux_next-v1-5-bc798edabc3a@quicinc.com>

On Freitag, 28. Juni 2024 20:32:39 MESZ Vikram Sharma wrote:
> This change enables IMX577 sensor driver for qcm6490.
> 
> Signed-off-by: Hariram Purushothaman <quic_hariramp@quicinc.com>
> Signed-off-by: Vikram Sharma <quic_vikramsa@quicinc.com>
> ---
>  drivers/i2c/busses/i2c-qcom-cci.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/i2c/busses/i2c-qcom-cci.c b/drivers/i2c/busses/i2c-qcom-cci.c
> index 414882c57d7f..10e6df566ae3 100644
> --- a/drivers/i2c/busses/i2c-qcom-cci.c
> +++ b/drivers/i2c/busses/i2c-qcom-cci.c
> @@ -817,6 +817,7 @@ static const struct of_device_id cci_dt_match[] = {
>  	 * Do not add any new ones unless they introduce a new config
>  	 */
>  	{ .compatible = "qcom,msm8916-cci", .data = &cci_v1_data},
> +	{ .compatible = "qcom,sc7280-cci", .data = &cci_v2_data},

Please read the comment above qcom,msm8916-cci.

And sc7280.dtsi already uses

  compatible = "qcom,sc7280-cci", "qcom,msm8996-cci";

So qcom,msm8996-cci with the same match data (cci_v2_data) gets used, so
just drop this patch.

Regards
Luca

>  	{ .compatible = "qcom,sdm845-cci", .data = &cci_v2_data},
>  	{ .compatible = "qcom,sm8250-cci", .data = &cci_v2_data},
>  	{ .compatible = "qcom,sm8450-cci", .data = &cci_v2_data},
> 
> 





  reply	other threads:[~2024-06-29  8:22 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-06-28 18:32 [PATCH 0/6] media: qcom: camss: Add sc7280 support Vikram Sharma
2024-06-28 18:32 ` [PATCH 1/6] media: dt-bindings: media: camss: Add qcom,sc7280-camss binding Vikram Sharma
2024-06-29 10:57   ` Bryan O'Donoghue
2024-07-01  8:58   ` Krzysztof Kozlowski
2024-06-28 18:32 ` [PATCH 2/6] arm64: dts: qcom: sc7280: Add support for camss Vikram Sharma
2024-06-29 11:53   ` Bryan O'Donoghue
2024-06-28 18:32 ` [PATCH 3/6] arm64: dts: qcom: sc7280: Add IMX577 camera sensor Vikram Sharma
2024-06-29 11:07   ` Bryan O'Donoghue
2024-06-29 13:10   ` Konrad Dybcio
2024-07-01  8:59   ` Krzysztof Kozlowski
2024-07-01 18:38   ` Dmitry Baryshkov
2024-06-28 18:32 ` [PATCH 4/6] arm64: dts: qcom: qcs6490-rb3gen2: Enable " Vikram Sharma
2024-06-29 11:22   ` Bryan O'Donoghue
2024-07-01  9:00   ` Krzysztof Kozlowski
2024-06-28 18:32 ` [PATCH 5/6] i2c: Enable IMX577 camera sensor for qcm6490 Vikram Sharma
2024-06-29  8:22   ` Luca Weiss [this message]
2024-07-01  9:01     ` Krzysztof Kozlowski
2024-07-01  9:01   ` Krzysztof Kozlowski
2024-06-28 18:32 ` [PATCH 6/6] media: qcom: camss: support for camss driver for sc7280 Vikram Sharma
2024-06-29 11:45   ` Bryan O'Donoghue
2024-07-01 19:22   ` Marion & Christophe JAILLET
2024-07-04 15:01 ` [PATCH 0/6] media: qcom: camss: Add sc7280 support Luca Weiss

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2902343.mvXUDI8C0e@g550jk \
    --to=luca@lucaweiss.eu \
    --cc=akapatra@quicinc.com \
    --cc=andersson@kernel.org \
    --cc=andi.shyti@kernel.org \
    --cc=bryan.odonoghue@linaro.org \
    --cc=conor+dt@kernel.org \
    --cc=cros-qcom-dts-watchers@chromium.org \
    --cc=devicetree@vger.kernel.org \
    --cc=hariramp@quicinc.com \
    --cc=konrad.dybcio@linaro.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-i2c@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=loic.poulain@linaro.org \
    --cc=mchehab@kernel.org \
    --cc=quic_hariramp@quicinc.com \
    --cc=quic_vikramsa@quicinc.com \
    --cc=rfoss@kernel.org \
    --cc=robh@kernel.org \
    --cc=todor.too@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox