From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753192AbcAGKFX (ORCPT ); Thu, 7 Jan 2016 05:05:23 -0500 Received: from gloria.sntech.de ([95.129.55.99]:37161 "EHLO gloria.sntech.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752458AbcAGKFU (ORCPT ); Thu, 7 Jan 2016 05:05:20 -0500 From: Heiko Stuebner To: Caesar Wang Cc: Ulf Hansson , linux-rockchip@lists.infradead.org, leecam@google.com, leozwang@google.com, keescook@google.com, Michael Turquette , Stephen Boyd , linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v2 04/12] clk: rockchip: rk3036: enable the CLK_IGNORE_UNUSED flag for sclk_i2s_out Date: Thu, 07 Jan 2016 11:05:06 +0100 Message-ID: <290434099.8XFZ9qmNRz@phil> User-Agent: KMail/4.14.10 (Linux/4.3.0-trunk-amd64; KDE/4.14.14; x86_64; ; ) In-Reply-To: <1452155155-16232-5-git-send-email-wxt@rock-chips.com> References: <1452155155-16232-1-git-send-email-wxt@rock-chips.com> <1452155155-16232-5-git-send-email-wxt@rock-chips.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Caesar, Am Donnerstag, 7. Januar 2016, 16:25:47 schrieb Caesar Wang: > SCLk_I2S_OUT is the noc bus clock for i2s module, this clock is used by > extra codecs. > > Due to it shouldn't belong to any driver, but we need it enabled, > so just mark it as the CLK_IGNORE_UNUSED flag. What makes you think it shouldn't belong to any driver? In most schematics I have, i2s_clkout is going to some clock-input of the audio codec - probably the MCLK input on your rt5616. And while the new rt5616 driver does not seem to do clock handling, it should just handle the clock using the normal APIs. Heiko