From: Markus Elfring <Markus.Elfring@web.de>
To: Alexandr Sapozhnikov <alsp705@gmail.com>,
linux-nvme@lists.infradead.org, lvc-project@linuxtesting.org,
Chaitanya Kulkarni <kch@nvidia.com>,
Christoph Hellwig <hch@lst.de>, Sagi Grimberg <sagi@grimberg.me>
Cc: LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] drivers: nvme: target: core: deref after null
Date: Mon, 10 Jun 2024 08:54:43 +0200 [thread overview]
Message-ID: <2904522f-8981-459c-8f8a-5dfa6de40331@web.de> (raw)
In-Reply-To: <20240607134340.11-1-alsp705@gmail.com>
> After having been compared to a NULL value at core.c:813,
> pointer '(**sq->ctrl).sqs' is dereferenced at core.c:838.
* Please choose another imperative wording for an improved change description.
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.10-rc2#n94
* Would you like to add the tag “Fixes” accordingly?
* How do you think about to use the summary phrase “Avoid null pointer dereference
in nvmet_sq_destroy()”?
* Is the subsystem specification “nvmet” more appropriate?
Regards,
Markus
next prev parent reply other threads:[~2024-06-10 6:55 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-07 13:43 [PATCH] drivers: nvme: target: core: deref after null Alexander Sapozhnikov
2024-06-10 4:34 ` Chaitanya Kulkarni
2024-06-10 6:54 ` Markus Elfring [this message]
2024-06-10 10:02 ` Sagi Grimberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2904522f-8981-459c-8f8a-5dfa6de40331@web.de \
--to=markus.elfring@web.de \
--cc=alsp705@gmail.com \
--cc=hch@lst.de \
--cc=kch@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=lvc-project@linuxtesting.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox