From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9F76537C909 for ; Mon, 4 May 2026 09:36:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777887398; cv=none; b=AprD77fNLWc4jHcpn7GnAs1niWRNGw2g+C8iqt0oWJ1m3BFPur3EjTsTN87tSiWJd8g37tgKd4KG22Oygn93lrakcW32KP3dMB58t9WSkmo6B7N38vKsah+aRytQFRolm6RPYcn0HZHYWm3dUmC6wyNLypKuolXVN7LSt1m5ZkY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777887398; c=relaxed/simple; bh=TaiE6VPRhMdw40zBsC2LL5E3LA6Izko2YcBBVpykQjs=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=V1aUcIPgp8BnGz7dEmOO072RprqKb09F2jFqaFGmZvxHQegzsTZCgjCjTHgkDDNd3TrPWGlkMkUxIA47dKI/hVA7gdYZOikGgXWBDLJXOCoAu9Vwz1vv4jgnUIQ5Tm2vErLPxzTNLFAf31nuyhlIjVY0G8RfFEE+ABIO6C7MenY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=djX/gzeU; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="djX/gzeU" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1777887395; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=nAq+++R2tX36PC5zxXCYWGZvvyeat8gPL+5FluYskoY=; b=djX/gzeUO+4rgaVt0iw32uf8+ASFM4ytdgFpn3mnv2Vi1whjg45HYghv3pNt0CtspDYUs+ kGJ7tG4z/xgRsveh+kupG0ZK7JhzimzMQI7hzhouLMqQRG8vp7Dgpq8mzuMxS7JaD7Iddk cvBN7JeJHxA7G+H5u9nYCc8FdujJt/s= Received: from mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-272-XpdB2FISPMCx6GsI_yi-_w-1; Mon, 04 May 2026 05:36:31 -0400 X-MC-Unique: XpdB2FISPMCx6GsI_yi-_w-1 X-Mimecast-MFC-AGG-ID: XpdB2FISPMCx6GsI_yi-_w_1777887388 Received: from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id CEEF0195609E; Mon, 4 May 2026 09:36:27 +0000 (UTC) Received: from [10.44.48.185] (unknown [10.44.48.185]) by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 1FDE51800357; Mon, 4 May 2026 09:36:20 +0000 (UTC) Message-ID: <290673a1-fb5b-4586-b44a-e109cc1a4629@redhat.com> Date: Mon, 4 May 2026 11:36:19 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net-next v2 1/2] dpll: move fractional-frequency-offset-ppt under pin-parent-device To: Jiri Pirko Cc: netdev@vger.kernel.org, Andrew Lunn , Arkadiusz Kubalewski , "David S. Miller" , Donald Hunter , Eric Dumazet , Jakub Kicinski , Jonathan Corbet , Leon Romanovsky , Mark Bloch , Michal Schmidt , Paolo Abeni , Pasi Vaananen , Petr Oros , Prathosh Satish , Saeed Mahameed , Shuah Khan , Simon Horman , Tariq Toukan , Vadim Fedorenko , linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-rdma@vger.kernel.org References: <20260430173611.3312596-1-ivecera@redhat.com> <20260430173611.3312596-2-ivecera@redhat.com> Content-Language: en-US From: Ivan Vecera In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.93 Hi Jiri, On 5/4/26 10:48 AM, Jiri Pirko wrote: > Thu, Apr 30, 2026 at 07:36:10PM +0200, ivecera@redhat.com wrote: >> Move the fractional-frequency-offset-ppt attribute from the top-level >> pin attributes into the pin-parent-device nested attribute set. This >> makes it consistent with phase-offset which is already per-parent and >> clarifies that FFO PPT represents the frequency difference between >> a pin and its parent DPLL device. >> >> The top-level fractional-frequency-offset attribute (in PPM) remains >> unchanged for backward compatibility. > > That is odd. The ppt one was added just for higher precision but was > semantically the same. Now you change it. Could you still treat both the > same? > WDYM? Keep fractional-frequency-offset-ppt at the top-level and add both fractional-frequency-offset and fractional-frequency-offset-ppt into pin-parent-device nested attribute set? Thanks, Ivan