From: David Woodhouse <dwmw2@infradead.org>
To: Andrzej Krzysztofowicz <ankry@green.mif.pg.gda.pl>
Cc: alan@lxorguk.ukuu.org.uk (Alan Cox),
andrewm@uow.edu.au, p_gortmaker@yahoo.com,
linux-kernel@vger.kernel.org (kernel list)
Subject: Re: [PATCH] net #3
Date: Wed, 30 May 2001 10:11:57 +0100 [thread overview]
Message-ID: <29071.991213917@redhat.com> (raw)
In-Reply-To: <200105300041.CAA04507@green.mif.pg.gda.pl>
In-Reply-To: <200105300041.CAA04507@green.mif.pg.gda.pl>
ankry@green.mif.pg.gda.pl said:
> -#ifdef CONFIG_ISAPNP
> +#if defined(CONFIG_ISAPNP) || (defined(CONFIG_ISAPNP_MODULE) && defined(MODULE))
The result here would be a 3c509 module which differs depending on whether
the ISAPNP module happened to be compiled at the same time or not.
The ISAPNP-specific parts of the code aren't large. Please consider
including them unconditionally instead.
--
dwmw2
next prev parent reply other threads:[~2001-05-30 9:24 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-05-30 0:41 [PATCH] net #3 Andrzej Krzysztofowicz
2001-05-30 5:49 ` Paul Gortmaker
2001-05-30 10:53 ` Andrzej Krzysztofowicz
2001-05-30 12:03 ` Keith Owens
2001-05-30 9:11 ` David Woodhouse [this message]
2001-05-30 10:11 ` Andrzej Krzysztofowicz
2001-05-30 10:39 ` Jeff Garzik
2001-05-30 11:02 ` Andrzej Krzysztofowicz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=29071.991213917@redhat.com \
--to=dwmw2@infradead.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=andrewm@uow.edu.au \
--cc=ankry@green.mif.pg.gda.pl \
--cc=linux-kernel@vger.kernel.org \
--cc=p_gortmaker@yahoo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox