From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2992563AbcBSAgG (ORCPT ); Thu, 18 Feb 2016 19:36:06 -0500 Received: from gloria.sntech.de ([95.129.55.99]:44524 "EHLO gloria.sntech.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1947867AbcBSAgE (ORCPT ); Thu, 18 Feb 2016 19:36:04 -0500 From: Heiko Stuebner To: Elaine Zhang Cc: wxt@rock-chips.com, linux-arm-kernel@lists.infradead.org, huangtao@rock-chips.com, zyw@rock-chips.com, xxx@rock-chips.com, jay.xu@rock-chips.com, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 1/6] rockchip: power-domain: make idle handling optional Date: Fri, 19 Feb 2016 01:05:38 +0100 Message-ID: <291170080.OevJ1dsWVH@phil> User-Agent: KMail/4.14.10 (Linux/4.3.0-1-amd64; KDE/4.14.14; x86_64; ; ) In-Reply-To: <1455764838-12928-2-git-send-email-zhangqing@rock-chips.com> References: <1455764838-12928-1-git-send-email-zhangqing@rock-chips.com> <1455764838-12928-2-git-send-email-zhangqing@rock-chips.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Am Donnerstag, 18. Februar 2016, 11:07:13 schrieb Elaine Zhang: > Not all new socs need to handle idle states on domain state changes, > so add the possibility to make them optional. > > Signed-off-by: Elaine Zhang > Signed-off-by: Heiko Stuebner What's up with the Signed-off-bys? I remember creating the draft of this change, so either my authorship of the patch should be retained or the Signed-off-by with my name removed :-) git send-email will keep patch authorship nicely. > --- > drivers/soc/rockchip/pm_domains.c | 11 ++++++++--- > 1 file changed, 8 insertions(+), 3 deletions(-) > > diff --git a/drivers/soc/rockchip/pm_domains.c > b/drivers/soc/rockchip/pm_domains.c index 6cdffb1..3dcc611 100644 > --- a/drivers/soc/rockchip/pm_domains.c > +++ b/drivers/soc/rockchip/pm_domains.c > @@ -63,14 +63,16 @@ struct rockchip_pmu { > }; > > #define to_rockchip_pd(gpd) container_of(gpd, struct rockchip_pm_domain, > genpd) +#define NULL_BIT -32 > +#define OVERFLOW_MASK 32 I don't really understand why you need this NULL_BIT / OVERFLOW_MASK. Defining the unset things to -1 should work nicely as well and is already regularly used elsewhere - so people will already know this scheme. That way you also don't need to introduce two new constants someone will have to look up later. > > #define DOMAIN(pwr, status, req, idle, ack) \ > { \ > .pwr_mask = BIT(pwr), \ > .status_mask = BIT(status), \ > - .req_mask = BIT(req), \ > - .idle_mask = BIT(idle), \ > - .ack_mask = BIT(ack), \ > + .req_mask = (req >= 0) ? BIT(req) : OVERFLOW_MASK, \ > + .idle_mask = (idle >= 0) ? BIT(idle) : OVERFLOW_MASK, \ > + .ack_mask = (ack >= 0) ? BIT(ack) : OVERFLOW_MASK, \ > } > > #define DOMAIN_RK3288(pwr, status, req) \ > @@ -96,6 +98,9 @@ static int rockchip_pmu_set_idle_request(struct > rockchip_pm_domain *pd, struct rockchip_pmu *pmu = pd->pmu; > unsigned int val; > > + if (pd_info->req_mask >= OVERFLOW_MASK) > + return 0; > + > regmap_update_bits(pmu->regmap, pmu->info->req_offset, > pd_info->req_mask, idle ? -1U : 0);