From: David Howells <dhowells@redhat.com>
To: Lizhi Xu <lizhi.xu@windriver.com>
Cc: dhowells@redhat.com,
syzbot+76f33569875eb708e575@syzkaller.appspotmail.com,
linux-afs@lists.infradead.org, linux-kernel@vger.kernel.org,
marc.dionne@auristor.com, syzkaller-bugs@googlegroups.com
Subject: Re: [PATCH] afs: Merge preference rule failure condition
Date: Mon, 06 Jan 2025 13:48:35 +0000 [thread overview]
Message-ID: <291912.1736171315@warthog.procyon.org.uk> (raw)
In-Reply-To: <20241226012616.2348907-1-lizhi.xu@windriver.com>
Lizhi Xu <lizhi.xu@windriver.com> wrote:
> argc = afs_split_string(&buf, argv, ARRAY_SIZE(argv));
> - if (argc < 0)
> - return argc;
> if (argc < 2)
> goto inval;
I think this needs to be slightly different. afs_split_string() will print
error messages and can return an error code, so we should go with that and set
ret to argc and go to done, not inval.
David
next prev parent reply other threads:[~2025-01-06 13:48 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-25 21:54 [syzbot] [afs?] WARNING: lock held when returning to user space in afs_proc_addr_prefs_write syzbot
2024-12-26 1:05 ` [syzbot] " syzbot
2024-12-26 1:26 ` [PATCH] afs: Merge preference rule failure condition Lizhi Xu
2025-01-06 13:48 ` David Howells [this message]
2025-01-06 14:06 ` [syzbot] [afs?] WARNING: lock held when returning to user space in afs_proc_addr_prefs_write David Howells
2025-01-06 14:27 ` syzbot
2025-01-06 16:44 ` David Howells
2025-01-06 17:05 ` syzbot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=291912.1736171315@warthog.procyon.org.uk \
--to=dhowells@redhat.com \
--cc=linux-afs@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lizhi.xu@windriver.com \
--cc=marc.dionne@auristor.com \
--cc=syzbot+76f33569875eb708e575@syzkaller.appspotmail.com \
--cc=syzkaller-bugs@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox