From: Alex Dubov <oakad@yahoo.com>
To: Maxim Levitsky <maximlevitsky@gmail.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH] My work on MemoryStick system
Date: Sat, 21 Aug 2010 06:50:12 -0700 (PDT) [thread overview]
Message-ID: <292036.65081.qm@web37607.mail.mud.yahoo.com> (raw)
In-Reply-To: <1282352917.13597.5.camel@maxim-laptop>
>
> I just tested this series with Jmicron, and unfortunelly
> there are bugs.
>
> * driver refuses to handle 26 byte TPC I use to read regs
> (sizeof(ms_registers). If I bump it to 32, it works.
It will work with any multiply of 4 (24 and 28 work as well). It's a known
"feature".
>
> * With this fix first few reads still fail.
> That means that card isn't detected always because boot
> blocks might not
> be read.
> Later card works fine.
>
> * Also I found out that msproblk.c allocates memory for
> attributes IO
> using stock kmalloc, and hangs that to driver.
> However if driver doesn't support such address, it will
> fail.
Why would hardware do anything at all with attribute memory space?
> I fixed that in my driver by properly calling dma_unmap_sg,
> and thus
> using SWIOTLB if necessary.
> But Jmicron driver doesn't unmap its sg.
> (Yet the system with Jmicron device has just one GB, so
> this isn't the
> problem I am seeing).
>
next prev parent reply other threads:[~2010-08-21 13:50 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-20 0:15 [PATCH] My work on MemoryStick system Maxim Levitsky
2010-08-20 0:15 ` [PATCH 1/3] memstick: add few common helpers Maxim Levitsky
2010-08-20 0:15 ` [PATCH 2/3] MEMSTICK: Add driver for Ricoh R5C592 Card reader Maxim Levitsky
2010-08-20 0:15 ` [PATCH 3/3] memstick: add support for Legacy memorysticks Maxim Levitsky
2010-08-21 1:08 ` [PATCH] My work on MemoryStick system Maxim Levitsky
2010-08-21 13:50 ` Alex Dubov [this message]
2010-08-21 14:56 ` Maxim Levitsky
2010-08-23 6:35 ` Alex Dubov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=292036.65081.qm@web37607.mail.mud.yahoo.com \
--to=oakad@yahoo.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maximlevitsky@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox