Re: [PATCH v2 7/9] media: i2c: ov772x: Remove soc_camera dependencies

jacopo mondi
2018-01-03T16:24:19Z

Hi Laurent,

On Wed, Jan 03, 2018 at 05:49:55PM +0200, Laurent Pinchart wrote:
> Hi Jacopo,
>
> >
> > DT based platforms won't have any info->xlkc_rate, so they should be
> > fine. I wonder how could I set rate in board code, as I'm just
> > registering an alias for the clock there...
>
> Exactly as done by the current code, get the clock and set the rate :) You can
> do that at initialization time, when you register the alias. Don't forget to
> put the clock too.

Interesting. I had no idea a clock rate is retained between get/put
cycles. I'll set the rate in board code (and now that I'm looking at
other SH boards code, it seems pretty common to do as a thing).

Thanks
j

>
> > >> + if (priv->clk) {
> > >> + ret = clk_prepare_enable(priv->clk);
> > >> + if (ret)
> > >> + return ret;
> > >> + }
> > >> +
> > >> + if (priv->pwdn_gpio) {
> > >> + gpiod_set_value(priv->pwdn_gpio, 1);
> > >> + usleep_range(500, 1000);
> > >> + }
> > >> +
> > >> + /* Reset GPIOs are shared in some platforms. */
> > >
> > > I'd make this a FIXME comment as this is really a hack.
> > >
> > > /*
> > > * FIXME: The reset signal is connected to a shared GPIO on some
> > > * platforms (namely the SuperH Migo-R). Until a framework becomes
> > > * available to handle this cleanly, request the GPIO temporarily
> > > * only to avoid conflicts.
> > > */
> > >
> > > Same for the tw9910 driver.
> >
> > Ack.
>
> --
> Regards,
>
> Laurent Pinchart
>