From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751102AbeBQJjJ (ORCPT ); Sat, 17 Feb 2018 04:39:09 -0500 Received: from gloria.sntech.de ([95.129.55.99]:56370 "EHLO gloria.sntech.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751054AbeBQJjH (ORCPT ); Sat, 17 Feb 2018 04:39:07 -0500 From: Heiko =?ISO-8859-1?Q?St=FCbner?= To: Klaus Goger Cc: linux-rockchip@lists.infradead.org, Mark Rutland , Rob Herring , linux-kernel@vger.kernel.org Subject: Re: [PATCH 4/4] arm64: dts: rockchip: add OPPs for rk3368-lion Date: Sat, 17 Feb 2018 10:38:57 +0100 Message-ID: <2925711.gDsaR89c37@diego> In-Reply-To: <20180130123931.50781-5-klaus.goger@theobroma-systems.com> References: <20180130123931.50781-1-klaus.goger@theobroma-systems.com> <20180130123931.50781-5-klaus.goger@theobroma-systems.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Am Dienstag, 30. Januar 2018, 13:39:31 CET schrieb Klaus Goger: > This adds CPU operation points for the RK3368. We only add them to the > the RK3368-uQ7 SoM (Lion) because patches for the SoC where reverted > in the past. > commit 6354a06cbaa8 ("Revert "arm64: dts: rockchip: Add basic cpu > frequencies for RK3368"") > > Signed-off-by: Klaus Goger > > --- > > arch/arm64/boot/dts/rockchip/rk3368-lion.dtsi | 96 > ++++++++++++++++++++++++--- 1 file changed, 88 insertions(+), 8 > deletions(-) > > diff --git a/arch/arm64/boot/dts/rockchip/rk3368-lion.dtsi > b/arch/arm64/boot/dts/rockchip/rk3368-lion.dtsi index > 72be1ae0854f..881f0b44c5b5 100644 > --- a/arch/arm64/boot/dts/rockchip/rk3368-lion.dtsi > +++ b/arch/arm64/boot/dts/rockchip/rk3368-lion.dtsi > @@ -11,6 +11,70 @@ > stdout-path = "serial0:115200n8"; > }; > > + cluster0_opp: opp-table0 { > + compatible = "operating-points-v2"; > + opp-shared; > + > + opp00 { > + opp-hz = /bits/ 64 <408000000>; > + opp-microvolt = <950000 950000 1350000>; > + clock-latency-ns = <40000>; > + }; > + opp01 { > + opp-hz = /bits/ 64 <600000000>; > + opp-microvolt = <950000 950000 1350000>; > + }; > + opp02 { > + opp-hz = /bits/ 64 <816000000>; > + opp-microvolt = <975000 975000 1350000>; > + }; > + opp03 { > + opp-hz = /bits/ 64 <1008000000>; > + opp-microvolt = <1050000 1050000 1350000>; > + }; > + opp04 { > + opp-hz = /bits/ 64 <1200000000>; > + opp-microvolt = <1150000 1150000 1350000>; > + }; > + opp05 { > + opp-hz = /bits/ 64 <1416000000>; > + opp-microvolt = <1300000 1300000 1350000>; > + turbo-mode; > + }; > + opp06 { > + opp-hz = /bits/ 64 <1512000000>; > + opp-microvolt = <1300000 1300000 1350000>; > + turbo-mode; > + }; > + }; > + > + cluster1_opp: opp-table1 { > + compatible = "operating-points-v2"; > + opp-shared; > + > + opp00 { > + opp-hz = /bits/ 64 <408000000>; > + opp-microvolt = <950000 950000 1350000>; > + clock-latency-ns = <40000>; > + }; > + opp01 { > + opp-hz = /bits/ 64 <600000000>; > + opp-microvolt = <950000 950000 1350000>; > + }; > + opp02 { > + opp-hz = /bits/ 64 <816000000>; > + opp-microvolt = <1025000 1025000 1350000>; > + }; > + opp03 { > + opp-hz = /bits/ 64 <1008000000>; > + opp-microvolt = <1125000 1125000 1350000>; > + }; > + opp04 { > + opp-hz = /bits/ 64 <1200000000>; > + opp-microvolt = <1225000 1225000 1350000>; > + }; > + }; > + > ext_gmac: gmac-clk { > compatible = "fixed-clock"; > clock-frequency = <125000000>; > @@ -239,36 +303,52 @@ > status = "okay"; > }; > > -&cpu_l0 { > +&cpu_b0 { > + clocks = <&cru ARMCLKB>; > cpu-supply = <&vdd_cpu>; > + operating-points-v2 = <&cluster0_opp>; > }; Looks ok for the time being until we have working general OPPs for rk3368 but can you please adapt the patch to not unecessarily touch the &cpu_XX handles? Thanks Heiko