From: Stephan Mueller <smueller@chronox.de>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: pebolle@tiscali.nl, andreas.steffen@strongswan.org,
tytso@mit.edu, sandyinchina@gmail.com,
linux-kernel@vger.kernel.org, linux-crypto@vger.kernel.org
Subject: Re: [PATCH v6 1/5] random: Blocking API for accessing nonblocking_pool
Date: Mon, 18 May 2015 15:26:13 +0200 [thread overview]
Message-ID: <2931045.EGfWxfUOa7@tauon> (raw)
In-Reply-To: <7743005.ngVOaoViLi@tauon>
Am Montag, 18. Mai 2015, 15:07:10 schrieb Stephan Mueller:
Hi Herbert,
>>
>>You can simplify this further and get rid of buf/nbytes. All
>>we need to know is whether the pool is ready. Everything else
>>can come from private.
>
>So, the async function is now just a notification of the caller. Sounds good
>with me.
>
I am just running into an interesting problem with a missing cancel operation:
a caller instantiates a DRBG handle and invokes the seeding operation. The
nonblocking_pool is not initialized. Therefore, the callback is put onto the
list for being processed later.
Now, the caller releases the DRBG handle *before* the callback is triggered.
The callback is triggered with a pointer that is invalid, but the pointer is
non-NULL. Therefore, I am not sure how to validate the pointer in the callback
function.
I would think that there is no other way than to add a cancel API call that
allows removing a list entry from the wait list.
Ciao
Stephan
next prev parent reply other threads:[~2015-05-18 13:26 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-13 19:54 [PATCH v6 0/5] Seeding DRBG with more entropy Stephan Mueller
2015-05-13 19:54 ` [PATCH v6 1/5] random: Blocking API for accessing nonblocking_pool Stephan Mueller
2015-05-15 6:46 ` Herbert Xu
2015-05-18 5:32 ` Stephan Mueller
2015-05-18 9:21 ` Herbert Xu
2015-05-18 13:07 ` Stephan Mueller
2015-05-18 13:26 ` Stephan Mueller [this message]
2015-05-18 15:02 ` Theodore Ts'o
2015-05-19 5:58 ` Stephan Mueller
2015-05-19 7:22 ` Herbert Xu
2015-05-19 7:35 ` Stephan Mueller
2015-05-19 7:51 ` Herbert Xu
2015-05-19 7:56 ` Stephan Mueller
2015-05-19 13:50 ` Theodore Ts'o
2015-05-19 14:18 ` Herbert Xu
2015-05-19 14:27 ` Stephan Mueller
2015-05-19 14:30 ` Herbert Xu
2015-05-19 14:36 ` Stephan Mueller
2015-05-19 22:55 ` Herbert Xu
2015-05-20 6:13 ` Stephan Mueller
2015-06-05 5:28 ` Herbert Xu
2015-06-05 9:50 ` Stephan Mueller
2015-05-13 19:55 ` [PATCH v6 2/5] crypto: drbg - prepare for async seeding Stephan Mueller
2015-05-13 19:55 ` [PATCH v6 3/5] crypto: drbg - add async seeding operation Stephan Mueller
2015-05-13 19:56 ` [PATCH v6 4/5] crypto: drbg - use Jitter RNG to obtain seed Stephan Mueller
2015-05-13 19:56 ` [PATCH v6 5/5] crypto: add jitterentropy RNG Stephan Mueller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2931045.EGfWxfUOa7@tauon \
--to=smueller@chronox.de \
--cc=andreas.steffen@strongswan.org \
--cc=herbert@gondor.apana.org.au \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pebolle@tiscali.nl \
--cc=sandyinchina@gmail.com \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox