Re: [RFC PATCH v2 08/34] x86/msr: Convert a native_wrmsr() use to native_wrmsrq()

Xin Li
2025-04-23T17:28:15Z

On 4/23/2025 8:51 AM, Dave Hansen wrote:
> On 4/22/25 01:21, Xin Li (Intel) wrote:
>> static __always_inline void sev_es_wr_ghcb_msr(u64 val)
>> {
>> - u32 low, high;
>> -
>> - low = (u32)(val);
>> - high = (u32)(val >> 32);
>> -
>> - native_wrmsr(MSR_AMD64_SEV_ES_GHCB, low, high);
>> + native_wrmsrq(MSR_AMD64_SEV_ES_GHCB, val);
>> }
>
> A note on ordering: Had this been a native_wrmsr()=>__wrmsr()
> conversion, it could be sucked into the tree easily before the big
> __wrmsr()=>native_wrmsrq() conversion.
>
> Yeah, you'd have to base the big rename on top of this. But with a
> series this big, I'd prioritize whatever gets it trimmed down.

Okay, I will focus on cleanup first.