Re: [RFC PATCH v2 13/34] x86/xen/msr: Remove the error pointer argument from set_reg()

Jürgen Groß
2025-04-24T10:11:16Z

[-- Attachment #1.1.1: Type: text/plain, Size: 577 bytes --]

On 22.04.25 10:21, Xin Li (Intel) wrote:
> set_reg() is used to write the following MSRs on Xen:
>
> MSR_FS_BASE
> MSR_KERNEL_GS_BASE
> MSR_GS_BASE
>
> But none of these MSRs are written using any MSR write safe API.
> Therefore there is no need to pass an error pointer argument to
> set_reg() for returning an error code to be used in MSR safe APIs.

set_seg(), please (further up, too).

>
> Remove the error pointer argument.
>
> Signed-off-by: Xin Li (Intel) <xin@zytor.com>

Reviewed-by: Juergen Gross <jgross@suse.com>

Juergen

[-- Attachment #1.1.2: OpenPGP public key --]
[-- Type: application/pgp-keys, Size: 3743 bytes --]

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 495 bytes --]