Re: [RFC PATCH v2 01/34] x86/msr: Move rdtsc{,_ordered}() to

Dave Hansen
2025-04-23T14:13:42Z

On 4/22/25 01:21, Xin Li (Intel) wrote:
> Relocate rdtsc{,_ordered}() from <asm/msr.h> to <asm/tsc.h>, and
> subsequently remove the inclusion of <asm/msr.h> in <asm/tsc.h>.
> Consequently, <asm/msr.h> must be included in several source files
> that previously did not require it.

I know it's mildly obvious but could you please add a problem statement
to these changelogs, even if it's just one little sentence?

For some reason, there are some TSC-related functions in the
MSR header even though there is a tsc.h header.

Relocate rdtsc{,_ordered}() and subsequently remove the
inclusion of <asm/msr.h> in <asm/tsc.h>. Consequently,
<asm/msr.h> must be included in several source files that
previously did not require it.

But I agree with the concept, so with this fixed:

Acked-by: Dave Hansen <dave.hansen@linux.intel.com>