Re: [PATCH v2 2/4] tools lib traceevent: Add options to plugins

Namhyung Kim
2014-06-04T14:00:53Z

Hi Jiri,

2014-06-04 (수), 13:42 +0200, Jiri Olsa:
> On Tue, Jun 03, 2014 at 03:51:22PM +0900, Namhyung Kim wrote:
> > On Mon, 02 Jun 2014 23:20:14 -0400, Steven Rostedt wrote:
> > > +void traceevent_plugin_free_options_list(char **list)
> > > +{
> > > + int i;
> > > +
> > > + if (!list)
> > > + return;
> > > +
> > > + if (list == (char **)((unsigned long)-1))
> >
> > It also should be:
> >
> > if (list == INVALID_PLUGIN_LIST_OPTION)
> >
> >
> > Other than that, the series looks good to me now!
>
> can I use your Acked-by?

Sure thing!

Acked-by: Namhyung Kim <namhyung@kernel.org>

Thanks,
Namhyung