Re: [PATCH v6 1/6] efi/cper, cxl: Prefix protocol error struct and function names with cxl_

Fan Ni
2025-02-04T00:12:25Z

On Thu, Jan 23, 2025 at 08:44:16AM +0000, Smita Koralahalli wrote:
> Rename the protocol error struct from struct cper_sec_prot_err to
> struct cxl_cper_sec_prot_err and cper_print_prot_err() to
> cxl_cper_print_prot_err() to maintain naming consistency. No
> functional changes.
>
> Signed-off-by: Smita Koralahalli <Smita.KoralahalliChannabasappa@amd.com>
> Reviewed-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> Reviewed-by: Ira Weiny <ira.weiny@intel.com>
> Reviewed-by: Dave Jiang <dave.jiang@intel.com>

Reviewed-by: Fan Ni <fan.ni@samsung.com>

> ---
> drivers/firmware/efi/cper.c | 4 ++--
> drivers/firmware/efi/cper_cxl.c | 3 ++-
> drivers/firmware/efi/cper_cxl.h | 5 +++--
> 3 files changed, 7 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/firmware/efi/cper.c b/drivers/firmware/efi/cper.c
> index b69e68ef3f02..8e5762f7ef2e 100644
> --- a/drivers/firmware/efi/cper.c
> +++ b/drivers/firmware/efi/cper.c
> @@ -624,11 +624,11 @@ cper_estatus_print_section(const char *pfx, struct acpi_hest_generic_data *gdata
> else
> goto err_section_too_small;
> } else if (guid_equal(sec_type, &CPER_SEC_CXL_PROT_ERR)) {
> - struct cper_sec_prot_err *prot_err = acpi_hest_get_payload(gdata);
> + struct cxl_cper_sec_prot_err *prot_err = acpi_hest_get_payload(gdata);
>
> printk("%ssection_type: CXL Protocol Error\n", newpfx);
> if (gdata->error_data_length >= sizeof(*prot_err))
> - cper_print_prot_err(newpfx, prot_err);
> + cxl_cper_print_prot_err(newpfx, prot_err);
> else
> goto err_section_too_small;
> } else {
> diff --git a/drivers/firmware/efi/cper_cxl.c b/drivers/firmware/efi/cper_cxl.c
> index a55771b99a97..cbaabcb7382d 100644
> --- a/drivers/firmware/efi/cper_cxl.c
> +++ b/drivers/firmware/efi/cper_cxl.c
> @@ -55,7 +55,8 @@ enum {
> USP, /* CXL Upstream Switch Port */
> };
>
> -void cper_print_prot_err(const char *pfx, const struct cper_sec_prot_err *prot_err)
> +void cxl_cper_print_prot_err(const char *pfx,
> + const struct cxl_cper_sec_prot_err *prot_err)
> {
> if (prot_err->valid_bits & PROT_ERR_VALID_AGENT_TYPE)
> pr_info("%s agent_type: %d, %s\n", pfx, prot_err->agent_type,
> diff --git a/drivers/firmware/efi/cper_cxl.h b/drivers/firmware/efi/cper_cxl.h
> index 86bfcf7909ec..0e3ab0ba17c3 100644
> --- a/drivers/firmware/efi/cper_cxl.h
> +++ b/drivers/firmware/efi/cper_cxl.h
> @@ -18,7 +18,7 @@
> #pragma pack(1)
>
> /* Compute Express Link Protocol Error Section, UEFI v2.10 sec N.2.13 */
> -struct cper_sec_prot_err {
> +struct cxl_cper_sec_prot_err {
> u64 valid_bits;
> u8 agent_type;
> u8 reserved[7];
> @@ -61,6 +61,7 @@ struct cper_sec_prot_err {
>
> #pragma pack()
>
> -void cper_print_prot_err(const char *pfx, const struct cper_sec_prot_err *prot_err);
> +void cxl_cper_print_prot_err(const char *pfx,
> + const struct cxl_cper_sec_prot_err *prot_err);
>
> #endif //__CPER_CXL_
> --
> 2.17.1
>

--
Fan Ni