From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932090AbcHVCwD (ORCPT ); Sun, 21 Aug 2016 22:52:03 -0400 Received: from mailout1.samsung.com ([203.254.224.24]:45357 "EHLO mailout1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753093AbcHVCwA (ORCPT ); Sun, 21 Aug 2016 22:52:00 -0400 X-AuditID: cbfee68d-f79286d000007a9a-1d-57ba68bedbea Subject: Re: [PATCH] mmc: dw_mmc: return -EILSEQ for EBE and SBE error To: Shawn Lin References: <1471664335-9650-1-git-send-email-shawn.lin@rock-chips.com> Cc: Ulf Hansson , linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org, Doug Anderson , Brian Norris , Heiko Stuebner , linux-rockchip@lists.infradead.org From: Jaehoon Chung Message-id: <293d07a2-a5dc-4f76-2d1d-e42531fbc49f@samsung.com> Date: Mon, 22 Aug 2016 11:51:42 +0900 User-Agent: Mozilla/5.0 (X11; Linux i686; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-version: 1.0 In-reply-to: <1471664335-9650-1-git-send-email-shawn.lin@rock-chips.com> Content-type: text/plain; charset=windows-1252 Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrNIsWRmVeSWpSXmKPExsWyRsSkUHdfxq5wg82vLS02fXzPanF22UE2 i/+PXrNaXN41h83iyP9+RotPD/4zW9x5sp7V4vjacAcOj9kNF1k87lzbw+axeUm9x99Z+1k8 tl+bx+zxeZNcAFsUl01Kak5mWWqRvl0CV8aO80fYC15IVMzYLd7AeEe4i5GTQ0LARKLz3WFW CFtM4sK99WxdjFwcQgIrGCW+HGtghynatWsjE0RiFqPElfcvoaoeMEo8W7gMrF1YwE3i4IsF TCC2iICGxI2z16GK5jJK3N59GKydWeAvo8TRjw/A5rIJ6Ehs/3YcrINXwE5i4czdYDaLgKrE hONHwGxRgTCJk+fOsUPUCEr8mHyPBcTmFPCQeLb4AZDNATRUT+L+RS2QMLOAvMTmNW+ZQXZJ CNxjl2h8+xxqpoDEt8mHwOolBGQlNh1ghnhNUuLgihssExjFZiHZMAth6iwkUxcwMq9iFE0t SC4oTkovMtQrTswtLs1L10vOz93ECIzD0/+e9e5gvH3A+hCjAAejEg9vhvaucCHWxLLiytxD jKZAR0xklhJNzgdGe15JvKGxmZGFqYmpsZG5pZmSOK+i1M9gIYH0xJLU7NTUgtSi+KLSnNTi Q4xMHJxSDYxXi1fNkPt++GpUIJva+YVLBAwWB8T3rT+rKaMtudbv2N2Ji51SluxpyeKtjTFO DS5J/Hbpg/5fnbVmhqveh9m8Kd3zI7FhJctm5n1ms54zJTaeOP2b8YSUvva1Hxo2LrMMfn/w 31f8paSnVGGrsuTvtLJoLsuPD0/yBzwM4q93OKDdeWrFgR9KLMUZiYZazEXFiQBeSgbVvgIA AA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrBIsWRmVeSWpSXmKPExsVy+t9jQd19GbvCDdp7TCw2fXzPanF22UE2 i/+PXrNaXN41h83iyP9+RotPD/4zW9x5sp7V4vjacAcOj9kNF1k87lzbw+axeUm9x99Z+1k8 tl+bx+zxeZNcAFtUA6NNRmpiSmqRQmpecn5KZl66rZJ3cLxzvKmZgaGuoaWFuZJCXmJuqq2S i0+ArltmDtA9SgpliTmlQKGAxOJiJX07TBNCQ9x0LWAaI3R9Q4LgeowM0EDCGsaMHeePsBe8 kKiYsVu8gfGOcBcjJ4eEgInErl0bmSBsMYkL99azdTFycQgJzGKUuPL+JZTzgFHi2cJlrCBV wgJuEgdfLADrEBHQkLhx9jpU0VxGidu7DzOBOMwCfxkljn58wA5SxSagI7H923GwDl4BO4mF M3eD2SwCqhITjh8Bs0UFwiROnjvHDlEjKPFj8j0WEJtTwEPi2eIHQDYH0FA9ifsXtUDCzALy EpvXvGWewAh0J0LHLISqWUiqFjAyr2KUSC1ILihOSs81ykst1ytOzC0uzUvXS87P3cQIjvVn 0jsYD+9yP8QowMGoxMP7gnVXuBBrYllxZe4hRgkOZiURXvs0oBBvSmJlVWpRfnxRaU5q8SFG U6A3JjJLiSbnA9NQXkm8obGJmZGlkbmhhZGxuZI47+P/68KEBNITS1KzU1MLUotg+pg4OKUa GPfMNDxuYyIS/uFpqGmtfvKl2pKoOUuvHPBXnfmxuuDjqRsfFOcvKJrbOvF+P6PTlWdc90pW fWA6yFD2QX/F+rcFB1bxPrr9/P/qTTrdycu50ty1+Sd37xHW+37puk7cPNES+ThZ+doElknO Jp7H//qsWvfPKvegRWDNcpmLEy+o/9i9RWihQ4wSS3FGoqEWc1FxIgCywZhPCwMAAA== DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Shawn, On 08/20/2016 12:38 PM, Shawn Lin wrote: > The following log we found indicate the fact that dw_mmc > didn't treat EBE or SBE as a similar problem as CRC error. > -EIO is quite not informative as it may indicate that the device > is broken rather than that of tuning stuff. > > ... > [ 89.057226] bcmsdh_sdmmc: Failed to Read byte F1:@0x1001f=ff, Err: -5 > [ 89.058811] bcmsdh_sdmmc: Failed to Read byte F1:@0x1001f=ff, Err: -5 > [ 89.059415] bcmsdh_sdmmc: Failed to Read byte F1:@0x1000e=ff, Err: -84 > [ 89.254248] dwmmc_rockchip fe310000.dwmmc: Successfully tuned phase to 199 > [ 89.273912] dhd_set_suspend: Remove extra suspend setting > [ 89.274478] dhd_enable_packet_filter: enter, value = 0 > 64 bytes from 112.90.83.112: icmp_seq=24 ttl=53 time=1321 ms > 64 bytes from 112.90.83.112: icmp_seq=25 ttl=53 time=319 ms > 64 bytes from 112.90.83.112: icmp_seq=26 ttl=53 time=69.8 ms > 64 bytes from 112.90.83.112: icmp_seq=27 ttl=53 time=37.5 ms > ... > > For the host, when failing to sample cmd's response due to > tuning stuff, we still return -EIO as it's quite vague to figure > out whether it related to signal or just the broken devices, especially > for the card type detection when booting kernel as all things go well > but the cmd set used. > > But for the data phase, if receiving the cmd's response which > carrys data transfer, we should have more confidence that it > is very probably related to the tuning stuff. s/carrys/carries > > Just as the log shown above, we sometimes suffer too much > this kind of pain as the dw_mmc return -EIO for the case, so > mmc-core will not do retune and caller drivers like bcm's wifi > driver, still retry the failure more and more untile dw_mmc > finally generate CRC. s/untile/until ? > > Adrian suggested that drivers who care the specific cases should > call mmc_retune_needed rather than doing it in mmc core. It makes > sense but I'm considering that -EILSEQ actually means illegal sequence > , so we use it for CRC cases. Meanwhile, SBE/EBE indicate the illegal > sequence of start bit or end bit for data0~7. So I realize that we should > use -EILSEQ for them both as well CRC cases. Make sense. SBE/EBE are illegal sequence error. Thanks! Best Regards, Jaehoon Chung > > Suggested-by: Adrian Hunter > Signed-off-by: Shawn Lin > --- > > drivers/mmc/host/dw_mmc.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/mmc/host/dw_mmc.c b/drivers/mmc/host/dw_mmc.c > index 32380d5..b36a4f5 100644 > --- a/drivers/mmc/host/dw_mmc.c > +++ b/drivers/mmc/host/dw_mmc.c > @@ -1691,11 +1691,11 @@ static int dw_mci_data_complete(struct dw_mci *host, struct mmc_data *data) > data->error = -ETIMEDOUT; > } else if (host->dir_status == > DW_MCI_RECV_STATUS) { > - data->error = -EIO; > + data->error = -EILSEQ; > } > } else { > /* SDMMC_INT_SBE is included */ > - data->error = -EIO; > + data->error = -EILSEQ; > } > > dev_dbg(host->dev, "data error, status 0x%08x\n", status); >