From: David Woodhouse <dwmw2@infradead.org>
To: "David S. Miller" <davem@redhat.com>
Cc: torvalds@transmeta.com, linux-kernel@vger.kernel.org
Subject: Re: recalc_sigpending() / recalc_sigpending_tsk() ?
Date: Fri, 01 Mar 2002 16:28:04 +0000 [thread overview]
Message-ID: <29409.1015000084@redhat.com> (raw)
In-Reply-To: <20020301.074940.54789154.davem@redhat.com>
In-Reply-To: <20020301.074940.54789154.davem@redhat.com> <Pine.LNX.4.33.0202280854250.15607-100000@home.transmeta.com> <22820.1014996781@redhat.com> <23330.1014997061@redhat.com>
davem@redhat.com said:
> Sorry, use an inline instead.
Thanks - that works, with a slight modification:
#if LINUX_VERSION_CODE < KERNEL_VERSION(2,5,5)
#include <linux/sched.h>
static inline void __recalc_sigpending(void)
{
recalc_sigpending(current);
}
#define recalc_sigpending() __recalc_sigpending ()
#endif
The goal is to have code that just works in 2.5 without compat crap like
jffs2_recalc_sigpending, and to fix it up in the headers only for older
kernels. Most of the changes in 2.5 (and indeed 2.4) have been done in a way
that makes such an approach feasible.
I had been assuming this was intentional good design; perhaps it was just a
fluke.
--
dwmw2
next prev parent reply other threads:[~2002-03-01 16:28 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-02-28 16:31 recalc_sigpending() / recalc_sigpending_tsk() ? David Woodhouse
2002-02-28 16:59 ` Linus Torvalds
2002-02-28 18:26 ` David Woodhouse
2002-03-01 15:33 ` David Woodhouse
2002-03-01 15:33 ` David S. Miller
2002-03-01 15:37 ` David Woodhouse
2002-03-01 15:49 ` David S. Miller
2002-03-01 16:28 ` David Woodhouse [this message]
2002-03-01 16:49 ` Linus Torvalds
2002-03-01 17:05 ` David Woodhouse
2002-03-01 17:40 ` David Howells
2002-03-01 17:43 ` David Woodhouse
2002-03-01 19:01 ` [PATCH] small proposal Martin Dalecki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=29409.1015000084@redhat.com \
--to=dwmw2@infradead.org \
--cc=davem@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@transmeta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox