From: Arnd Bergmann <arnd@arndb.de>
To: linux-arm-kernel@lists.infradead.org
Cc: Sonny Rao <sonnyrao@chromium.org>,
Mark Rutland <Mark.Rutland@arm.com>,
devicetree@vger.kernel.org,
Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
pawel.moll@arm.com, ijc+devicetree@hellion.org.uk,
Marc Zyngier <marc.zyngier@arm.com>,
Catalin Marinas <catalin.marinas@arm.com>,
Daniel Lezcano <daniel.lezcano@linaro.org>,
Will Deacon <will.deacon@arm.com>,
linux-kernel@vger.kernel.org, robh+dt@kernel.org,
Doug Anderson <dianders@chromium.org>,
galak@codeaurora.org, Sudeep Holla <Sudeep.Holla@arm.com>,
Olof Johansson <olof@lixom.net>,
Nathan Lynch <Nathan_Lynch@mentor.com>,
Thomas Gleixner <tglx@linutronix.de>,
Stephen Boyd <sboyd@codeaurora.org>
Subject: Re: [PATCH v3] clocksource: arch_timer: Allow the device tree to specify uninitialized CNTVOFF
Date: Tue, 07 Oct 2014 09:40:57 +0200 [thread overview]
Message-ID: <2943095.1HCacZ7zIg@wuerfel> (raw)
In-Reply-To: <1412663852-32681-1-git-send-email-sonnyrao@chromium.org>
On Monday 06 October 2014 23:37:32 Sonny Rao wrote:
>
> +#ifdef CONFIG_ARM
> + /*
> + * If we cannot rely on firmware initializing the CNTVOFF then
> + * we should use the physical timers instead.
> + */
> + if (of_property_read_bool(np, "arm,cntvoff-not-fw-configured"))
> + arch_timer_use_virtual = false;
> +#endif
> +
>
Sorry for the nitpicking, but can this please use
if (IS_ENABLED(CONFIG_ARM))
to avoid the ugly #ifdef?
Arnd
next prev parent reply other threads:[~2014-10-07 7:41 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-07 6:37 [PATCH v3] clocksource: arch_timer: Allow the device tree to specify uninitialized CNTVOFF Sonny Rao
2014-10-07 7:40 ` Arnd Bergmann [this message]
2014-10-07 10:21 ` Mark Rutland
2014-10-07 16:46 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2943095.1HCacZ7zIg@wuerfel \
--to=arnd@arndb.de \
--cc=Mark.Rutland@arm.com \
--cc=Nathan_Lynch@mentor.com \
--cc=Sudeep.Holla@arm.com \
--cc=catalin.marinas@arm.com \
--cc=daniel.lezcano@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=dianders@chromium.org \
--cc=galak@codeaurora.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=marc.zyngier@arm.com \
--cc=olof@lixom.net \
--cc=pawel.moll@arm.com \
--cc=robh+dt@kernel.org \
--cc=sboyd@codeaurora.org \
--cc=sonnyrao@chromium.org \
--cc=tglx@linutronix.de \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox