Re: [PATCH 1/1] tpm: fix cause of SMP stack traces

Kylene Hall
2005-01-18T23:08:10Z

On Tue, 2005-01-18 at 16:47, Greg KH wrote:
> On Tue, Jan 18, 2005 at 04:29:23PM -0600, Kylene Hall wrote:
> > There were misplaced spinlock acquires and releases in the probe, open,
> > close and release paths which were causing might_sleep and schedule while
> > atomic error messages accompanied by stack traces when the kernel was
> > compiled with SMP support. Bug reported by Reben Jenster
> > <ruben@hotheads.de>
>
> Where exactly where the trace errors coming from? I don't see anything
> in the open path that might have caused it.
>
True the open path was not affected.
> Anyway, Chris is right, just changing this to _irqsave will not fix the
> issue.
Fixing will reissue the patch momentarily.
>
> thanks,
>
> greg k-h
>