Re: Little rework of usbserial in 2.4

Pete Zaitcev
2004-12-21T20:53:16Z

On Sun, 12 Dec 2004 15:47:44 -0800, Nish Aravamudan <nish.aravamudan@gmail.com> wrote:

> > diff -urpN -X dontdiff linux-2.4.28-bk3/drivers/usb/serial/usbserial.c linux-2.4.28-bk3-sx4/drivers/usb/serial/usbserial.c
> > --- linux-2.4.28-bk3/drivers/usb/serial/usbserial.c 2004-11-22 23:04:19.000000000 -0800

> > @@ -1803,6 +1820,12 @@ static void __exit usb_serial_exit(void)
> >
> > usb_deregister(&usb_serial_driver);
> > tty_unregister_driver(&serial_tty_driver);
> > +
> > + while (!list_empty(&usb_serial_driver_list)) {
> > + err("%s - module is in use, hanging...\n", __FUNCTION__);
> > + set_current_state(TASK_UNINTERRUPTIBLE);
> > + schedule_timeout(5*HZ);
> > + }

> Please consider using msleep() here instead of schedule_timeout().

No, Nish, it's 2.4. There's no msleep here. I can create something like
"drivers/usb/serial/compat26.h", similar to include/linux/libata-compat.h,
but I do not think it's worth the trouble at present juncture.

-- Pete