Re: Little rework of usbserial in 2.4

Nish Aravamudan
2004-12-12T23:47:51Z

On Sat, 27 Nov 2004 17:35:58 -0800, Pete Zaitcev <zaitcev@redhat.com> wrote:
> Hi, Greg, hi, guys:

<snip>

> diff -urpN -X dontdiff linux-2.4.28-bk3/drivers/usb/serial/usbserial.c linux-2.4.28-bk3-sx4/drivers/usb/serial/usbserial.c
> --- linux-2.4.28-bk3/drivers/usb/serial/usbserial.c 2004-11-22 23:04:19.000000000 -0800
> +++ linux-2.4.28-bk3-sx4/drivers/usb/serial/usbserial.c 2004-11-27 10:36:49.000000000 -0800

<snip>

> @@ -1803,6 +1820,12 @@ static void __exit usb_serial_exit(void)
>
> usb_deregister(&usb_serial_driver);
> tty_unregister_driver(&serial_tty_driver);
> +
> + while (!list_empty(&usb_serial_driver_list)) {
> + err("%s - module is in use, hanging...\n", __FUNCTION__);
> + set_current_state(TASK_UNINTERRUPTIBLE);
> + schedule_timeout(5*HZ);
> + }

Please consider using msleep() here instead of schedule_timeout().

Thanks,
Nish