Re: [8/many] acrypto: crypto_dev.c

[Nish Aravamudan <nish.aravamudan@gmail.com>]

On Tue, 8 Mar 2005 02:14:31 +0300, Evgeniy Polyakov <johnpol@2ka.mipt.ru> wrote:
> On Mon, 7 Mar 2005 14:40:52 -0800
> Nish Aravamudan <nish.aravamudan@gmail.com> wrote:
> 
> > On Mon, 7 Mar 2005 23:37:34 +0300, Evgeniy Polyakov <johnpol@2ka.mipt.ru> wrote:
> > > --- /tmp/empty/crypto_dev.c     1970-01-01 03:00:00.000000000 +0300
> > > +++ ./acrypto/crypto_dev.c      2005-03-07 20:35:36.000000000 +0300
> > > @@ -0,0 +1,421 @@
> > > +/*
> > > + *     crypto_dev.c
> >
> > <snip>
> >
> > > +                       while (atomic_read(&__dev->refcnt)) {

<snip>

> > > +                               set_current_state(TASK_UNINTERRUPTIBLE);
> > > +                               schedule_timeout(HZ);
> >
> > I don't see any wait-queues in the immediate area of this code. Can
> > this be an ssleep(1)?
> 
> Yes, you are right, this loop just spins until all pending sessions
> are removed from given crypto device, so it can just ssleep(1) here.

Would you like me to send an incremental patch or will you be changing
it yourself?

Thanks,
Nish