Re: [PATCH 1a/7] dlm: core locking

[Nish Aravamudan <nish.aravamudan@gmail.com>]

On 4/25/05, David Teigland <teigland@redhat.com> wrote:
> [Apologies, patch 1 was too large on its own.]
> 
> The core dlm functions.  Processes dlm_lock() and dlm_unlock() requests.
> Creates lockspaces which give applications separate contexts/namespaces in
> which to do their locking.  Manages locks on resources' grant/convert/wait
> queues.  Sends and receives high level locking operations between nodes.
> Delivers completion and blocking callbacks (ast's) to lock holders.
> Manages the distributed directory that tracks the current master node for
> each resource.
> 
> Signed-Off-By: Dave Teigland <teigland@redhat.com>
> Signed-Off-By: Patrick Caulfield <pcaulfie@redhat.com>

<snip>

> --- a/drivers/dlm/lockspace.c   1970-01-01 07:30:00.000000000 +0730
> +++ b/drivers/dlm/lockspace.c   2005-04-25 22:52:03.956816760 +0800

<snip>

> +int dlm_scand(void *data)
> +{
> +       struct dlm_ls *ls;
> +
> +       while (!kthread_should_stop()) {
> +               list_for_each_entry(ls, &lslist, ls_list)
> +                       dlm_scan_rsbs(ls);
> +               set_current_state(TASK_INTERRUPTIBLE);
> +               schedule_timeout(DLM_SCAN_SECS * HZ);
> +       }
> +       return 0;
> +}

<snip>

> +static void remove_lockspace(struct dlm_ls *ls)
> +{
> +       for (;;) {
> +               spin_lock(&lslist_lock);
> +               if (ls->ls_count == 0) {
> +                       list_del(&ls->ls_list);
> +                       spin_unlock(&lslist_lock);
> +                       return;
> +               }
> +               spin_unlock(&lslist_lock);
> +               set_current_state(TASK_INTERRUPTIBLE);
> +               schedule_timeout(HZ);
> +       }
> +}

<snip>

These can both be msleep_interruptible() calls?

Thanks,
Nish