From: David Howells <dhowells@redhat.com>
To: "Mike Frysinger" <vapier.adi@gmail.com>
Cc: dhowells@redhat.com, "Christoph Lameter" <clameter@sgi.com>,
"Pekka J Enberg" <penberg@cs.helsinki.fi>,
mpm@selenic.com, lethal@linux-sh.org,
linux-kernel@vger.kernel.org, "Bryan Wu" <cooloney@kernel.org>
Subject: Re: [PATCH] nommu: fix kobjsize() for SLOB and SLUB
Date: Thu, 29 May 2008 14:03:28 +0100 [thread overview]
Message-ID: <29553.1212066208@redhat.com> (raw)
In-Reply-To: <8bd0f97a0805281335q7a26be97ie83feef6e7da2276@mail.gmail.com>
Mike Frysinger <vapier.adi@gmail.com> wrote:
> > I fixed it by setting ARCH_KMALLOC_MINALIGN and ARCH_SLAB_MINALIGN.
>
> what was the change exactly ?
The attached patch.
David
---
[PATCH] FRV: Specify the minimum slab/kmalloc alignment
From: David Howells <dhowells@redhat.com>
Specify the minimum slab/kmalloc alignment to be 8 bytes. This fixes a crash
when SLOB is selected as the memory allocator. The FRV arch needs this so
that it can use the load- and store-double instructions without faulting. By
default SLOB sets the minimum to be 4 bytes.
Signed-off-by: David Howells <dhowells@redhat.com>
---
include/asm-frv/mem-layout.h | 7 +++++++
1 files changed, 7 insertions(+), 0 deletions(-)
diff --git a/include/asm-frv/mem-layout.h b/include/asm-frv/mem-layout.h
index 734a1d0..2947764 100644
--- a/include/asm-frv/mem-layout.h
+++ b/include/asm-frv/mem-layout.h
@@ -31,6 +31,13 @@
#define PAGE_MASK (~(PAGE_SIZE-1))
+/*
+ * the slab must be aligned such that load- and store-double instructions don't
+ * fault if used
+ */
+#define ARCH_KMALLOC_MINALIGN 8
+#define ARCH_SLAB_MINALIGN 8
+
/*****************************************************************************/
/*
* virtual memory layout from kernel's point of view
next prev parent reply other threads:[~2008-05-29 13:10 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-22 16:09 [PATCH] nommu: fix kobjsize() for SLOB and SLUB Pekka J Enberg
2008-05-22 16:48 ` Christoph Lameter
2008-05-22 23:40 ` Paul Mundt
2008-05-22 23:45 ` Christoph Lameter
2008-05-22 23:50 ` Paul Mundt
2008-05-23 0:04 ` Christoph Lameter
2008-05-28 13:12 ` David Howells
2008-05-28 13:17 ` Pekka J Enberg
2008-05-28 13:40 ` David Howells
2008-05-28 14:09 ` David Howells
2008-05-28 17:26 ` Christoph Lameter
2008-05-28 17:38 ` David Howells
2008-05-28 20:35 ` Mike Frysinger
2008-05-29 13:03 ` David Howells [this message]
2008-05-29 20:25 ` Mike Frysinger
2008-05-29 20:30 ` Christoph Lameter
2008-05-29 20:51 ` Mike Frysinger
2008-05-29 21:29 ` Christoph Lameter
2008-05-30 4:18 ` Mike Frysinger
2008-05-28 14:27 ` David Howells
[not found] <Pine.LNX.4.64.0805281646470.27125@sbz-30.cs.Helsinki.FI>
[not found] ` <20080528153648.GA27783@linux-sh.org>
2008-05-28 20:03 ` Pekka Enberg
2008-05-28 20:25 ` Christoph Lameter
2008-05-28 20:25 ` Pekka Enberg
2008-05-28 20:29 ` Christoph Lameter
2008-05-29 13:08 ` David Howells
2008-05-29 13:21 ` Pekka J Enberg
2008-05-29 21:12 ` Paul Mundt
2008-06-01 7:58 ` Pekka Enberg
2008-06-01 8:22 ` Pekka J Enberg
2008-06-01 8:24 ` Paul Mundt
2008-06-01 8:36 ` Pekka J Enberg
2008-06-01 9:13 ` Pekka J Enberg
2008-06-01 10:24 ` Paul Mundt
2008-06-01 10:29 ` Pekka Enberg
2008-06-01 11:21 ` Paul Mundt
2008-06-01 11:30 ` Pekka J Enberg
2008-06-02 5:59 ` Paul Mundt
2008-06-02 6:32 ` Pekka Enberg
2008-06-02 6:50 ` Paul Mundt
2008-06-02 6:58 ` Pekka Enberg
2008-06-02 7:01 ` Paul Mundt
2008-06-01 8:22 ` Paul Mundt
2008-05-29 15:00 ` Christoph Lameter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=29553.1212066208@redhat.com \
--to=dhowells@redhat.com \
--cc=clameter@sgi.com \
--cc=cooloney@kernel.org \
--cc=lethal@linux-sh.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mpm@selenic.com \
--cc=penberg@cs.helsinki.fi \
--cc=vapier.adi@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox