From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756012AbYE2NQA (ORCPT ); Thu, 29 May 2008 09:16:00 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751730AbYE2NPx (ORCPT ); Thu, 29 May 2008 09:15:53 -0400 Received: from mx1.redhat.com ([66.187.233.31]:45462 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751751AbYE2NPv (ORCPT ); Thu, 29 May 2008 09:15:51 -0400 Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: References: <20080528153648.GA27783@linux-sh.org> <483DBA85.2060502@cs.helsinki.fi> <483DBFC3.1070108@cs.helsinki.fi> To: Christoph Lameter Cc: dhowells@redhat.com, Pekka Enberg , Paul Mundt , LKML , cooloney@kernel.org, akpm@linux-foundation.org, mpm@selenic.com Subject: Re: [PATCH] nommu: fix kobjsize() for SLOB and SLUB X-Mailer: MH-E 8.0.3+cvs; nmh 1.2-20070115cvs; GNU Emacs 23.0.50 Date: Thu, 29 May 2008 14:08:37 +0100 Message-ID: <29611.1212066517@redhat.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Christoph Lameter wrote: > Could the nommu people either tell us what this is all about? Or junk the > code. This looks very wrong. ELF-FDPIC is currently using kobjsize() so that it can expand the heap/stack segment to fill up the entirety of its allocation. It's probably worth dropping that, though. NOMMU mmap() is using kobjsize()/ksize() to keep track of the number of bytes allocated and the amount of dead space. We can probably ditch that too. However, fs/proc/task_nommu.c uses kobjsize() quite a bit to determine how much metadata space a process is carrying around. We could just use sizeof(), I suppose, and not bother calculating the slack. David